Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variables to manage kubelet parameters #8796

Merged
merged 1 commit into from
May 9, 2022
Merged

feat: add variables to manage kubelet parameters #8796

merged 1 commit into from
May 9, 2022

Conversation

alegrey91
Copy link
Contributor

@alegrey91 alegrey91 commented May 6, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR covers the kubelet parameters makeIPTablesUtilChains and streamingConnectionIdleTimeout for CIS Benchmark.
It allows the user to make a complete hardening configuration through IaC.

Which issue(s) this PR fixes:

Fixes #8728

Special notes for your reviewer:
This PR is also referred to this: #8773

Does this PR introduce a user-facing change?:

Add variables to manage kubelet parameters (`kubelet_streaming_connection_idle_timeout` / `kubelet_make_iptables_util_chains`)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alegrey91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi May 6, 2022 15:12
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2022
@cristicalin
Copy link
Contributor

Thanks for this @alegrey91 !

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegrey91, cristicalin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@oomichi
Copy link
Contributor

oomichi commented May 6, 2022

nice addition

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
@alegrey91
Copy link
Contributor Author

Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 37a5271 into kubernetes-sigs:master May 9, 2022
@alegrey91 alegrey91 mentioned this pull request May 9, 2022
4 tasks
@floryut floryut added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 16, 2022
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for streamingConnectionIdleTimeout and makeIPTablesUtilChains parameters for kubelet
5 participants