Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-ovn]: update kube-ovn version and sync some feature #8790

Merged
merged 3 commits into from
May 12, 2022

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented May 5, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
sync yaml from https://raw.githubusercontent.com/alauda/kube-ovn/release-1.9/dist/images/install.sh :
kube-ovn vlan mode
ipv6/ipv4 dual stack(Local env test ok, but kubespray CI failed)
...

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[kube-ovn] Sync some feature with upstream

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 5, 2022
@liupeng0518 liupeng0518 marked this pull request as draft May 5, 2022 15:44
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2022
@liupeng0518 liupeng0518 force-pushed the kube-ovn-more-config branch from 9dda899 to 008156a Compare May 5, 2022 15:59
@liupeng0518 liupeng0518 changed the title [kube-ovn]: some feature [kube-ovn]: update kube-ovn version and sync some feature May 5, 2022
@liupeng0518 liupeng0518 force-pushed the kube-ovn-more-config branch 3 times, most recently from 947aca4 to 72cb618 Compare May 6, 2022 05:55
@liupeng0518 liupeng0518 marked this pull request as ready for review May 6, 2022 10:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bozzo May 6, 2022 10:01
@liupeng0518 liupeng0518 marked this pull request as draft May 6, 2022 10:12
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2022
@liupeng0518 liupeng0518 marked this pull request as ready for review May 6, 2022 13:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jayonlau May 6, 2022 13:20
Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @liupeng0518 !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, liupeng0518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@liupeng0518
Copy link
Member Author

/retest

@cristicalin
Copy link
Contributor

@liupeng0518 looks like you may need to redo the rebase as something went wrong.

The usual way is to do it like this:

git checkout master
git pull
git checkout $feature_branch
git rebase -i master
# solve any rebase conflicts
git push --force

@liupeng0518 liupeng0518 force-pushed the kube-ovn-more-config branch from 35d349e to 9f4546d Compare May 12, 2022 01:06
@cristicalin
Copy link
Contributor

Nice work @liupeng0518

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit f26f544 into kubernetes-sigs:master May 12, 2022
@floryut floryut added the kind/network Network section in the release note label May 16, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
…-sigs#8790)

* [kube-ovn]: some feature

kube-ovn vlan mode
ipv6/ipv4 dual stack
...

* remove unused env

* fix readinessprobe
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
…-sigs#8790)

* [kube-ovn]: some feature

kube-ovn vlan mode
ipv6/ipv4 dual stack
...

* remove unused env

* fix readinessprobe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants