-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow replacement of address prefixes for all images #8764
Allow replacement of address prefixes for all images #8764
Conversation
|
Welcome @ErikJiang! |
Hi @ErikJiang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ErikJiang please don't mark questions as resolved without answering them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the script.
Some comments in the pull request.
/cc @oomichi
@cyclinder: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test Kubespray CI - packet_ubuntu20-calico-aio |
@cyclinder: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ErikJiang: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
PTAL @cristicalin @oomichi |
@ErikJiang the current CI errors can be fixed by rebasing your PR on the latest master branch. |
/test all |
Signed-off-by: bo.jiang <[email protected]>
Thank you for updating this @ErikJiang /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…#8764) Signed-off-by: bo.jiang <[email protected]>
…#8764) Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
first of all, a big thanks to @oomichi for this script, its functionality is very useful to me.
but I found in actual use that it doesn't seem to work properly for registering some private registry images to the local registry.
I think the reason is that the script only processes four types of image prefixes “k8s.gcr.io”, “gcr.io”, “docker.io”, and “quay.io”, and my image prefixes are not of these types.
I modified the script to support prefix processing for all images, and I added the settings to hosts to avoid "no such host" error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: