-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calico: add new versions & related checksums #8745
Conversation
Hi @mzaian. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the hashes in alphabetical order which makes them easier to maintain in the long run.
Thanks for updating. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to come back on this but my mind was focused on getting the CI back up yesterday.
For components outside the core (kube, etcd) we usually keep just one version or one of each major version, in this case I recommend removing the 3.2x.y-1 versions as part of this PR and also bumping calico to the latest 3.22.y version (when setting up the new CI I came across an issue with upset versions that required bumping the version to 3.22.1)
Hello @cristicalin I've made the changes and thank you for your input. |
|
/approve /cc @oomichi to lgtm again |
@cristicalin: GitHub didn't allow me to request PR reviews from the following users: lgtm, again, to. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds calico versions v3.21.5 & v3.22.2 and sets default calico version to v3.21.5
Does this PR introduce a user-facing change?: