Ensure containerd service unmasking

[rickerc]

Force systemd to unmask and start service when adding containerd systemd service

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Ensures that the systemd containerd service is not masked when kubespray adds it, regardless of the initial system state (without this, transitioning from OS-deployed systemd-managed containerd to kubespray deployed systemd-managed containerd can fail because the kubespray uninstall of the OS deployment of containerd leaves the service masked in systemd)

Which issue(s) this PR fixes:

Fixes #8725 #8734

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[containerd] Ensure containerd service unmasking

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rickerc / name: Chris Ricker (db3f82b)

[k8s-ci-robot]

Welcome @rickerc!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rickerc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rickerc]

/retest

[k8s-ci-robot]

@rickerc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

@rickerc please see the related issue #8734 which appears to be related. I'm guessing the reset operation also causes similar symptoms to what you experienced so we should try to fix this for all CRIs, not just containerd.

Secondly, due to the CI outage of the last couple of days you will need to close and re-open the PR so the new CI creates a new pipeline.

[cristicalin]

/ok-to-test

[rickerc]

Unmasking added for a couple of other runtimes to help with #8734

At least with containerd the masking is specifically needed because of the combination of apt and the workflow of the containerd deployment ansible which does:

1. stop apt-installed runtime
   

2. uninstall apt-installed runtime
   

3. download known good binary
   

4. register known good as systemd service
   

5. systemd start systemd service then fails because step 2 above left service masked
   

It won't be universal to all the runtimes because the runtime install ansible doesn't always follow the above flow, etc. I don't think this will be seen on rpm based distros either -- might vary with rpm version but at least in light testing I only see the above 5 steps fail with ubuntu not rhel

[cristicalin]

Thanks for doing this @rickerc !
Note, you might need to rebase this PR on the latest master branch for the CI jobs to complete.

[cristicalin]

Thanks for doing this @rickerc !

/approve

[floryut]

/lgtm

Thank you @rickerc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, rickerc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment