Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for EventRateLimit plugin configuration #8711

Merged
merged 2 commits into from
May 2, 2022
Merged

add support for EventRateLimit plugin configuration #8711

merged 2 commits into from
May 2, 2022

Conversation

alegrey91
Copy link
Contributor

@alegrey91 alegrey91 commented Apr 13, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
Currently is not possible to configure the EventRateLimit admission plugin (and the others too) through kubespray. This could be really useful in the hardening perspective (example CIS 1.2.9 of CIS Kubernetes Benchmark).

Which issue(s) this PR fixes:

Fixes #8686

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The user can decide to enable admission plugin configuartion through kube_apiserver_admission_control_config_file: true and configure the EventRateLimit using the following structure:

kube_apiserver_admission_event_rate_limits:
<limit_name>:
  type: <limit_type>
  qps: <qps_value>
  burst: <burst_value>
  cache_size: <cache_size_value>

Does this PR introduce a user-facing change?:

add support for `EventRateLimit` plugin configuration

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alegrey91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!
Just a few comments.

/ok-to-test

roles/kubernetes/control-plane/defaults/main/main.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2022
@alegrey91 alegrey91 requested a review from oomichi April 22, 2022 15:31
@cristicalin
Copy link
Contributor

@alegrey91 note that you might need to rebase this PR on the latest state of master branch for all the CI jobs to succeed.

@alegrey91
Copy link
Contributor Author

@alegrey91 note that you might need to rebase this PR on the latest state of master branch for all the CI jobs to succeed.

Ok @cristicalin, I'll do it asap :)

@alegrey91
Copy link
Contributor Author

Done!

@cristicalin
Copy link
Contributor

Thanks for doing this @alegrey91 !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegrey91, cristicalin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
docs/vars.md Outdated Show resolved Hide resolved
@alegrey91 alegrey91 requested a review from oomichi April 30, 2022 08:19
@oomichi
Copy link
Contributor

oomichi commented May 2, 2022

Thanks for updating @alegrey91

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit fa1d222 into kubernetes-sigs:master May 2, 2022
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 27, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
…s#8711)

* feat: add support for EventRateLimit admission plugin

* docs: add documentation about admission_control_config_file and EventRateLimit configuration
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
…s#8711)

* feat: add support for EventRateLimit admission plugin

* docs: add documentation about admission_control_config_file and EventRateLimit configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the EventRateLimit admission plugin
4 participants