-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for EventRateLimit
plugin configuration
#8711
Conversation
Hi @alegrey91. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
Just a few comments.
/ok-to-test
@alegrey91 note that you might need to rebase this PR on the latest state of master branch for all the CI jobs to succeed. |
Ok @cristicalin, I'll do it asap :) |
Done! |
Thanks for doing this @alegrey91 ! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alegrey91, cristicalin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for updating @alegrey91 /lgtm |
…s#8711) * feat: add support for EventRateLimit admission plugin * docs: add documentation about admission_control_config_file and EventRateLimit configuration
…s#8711) * feat: add support for EventRateLimit admission plugin * docs: add documentation about admission_control_config_file and EventRateLimit configuration
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently is not possible to configure the EventRateLimit admission plugin (and the others too) through kubespray. This could be really useful in the hardening perspective (example CIS 1.2.9 of CIS Kubernetes Benchmark).
Which issue(s) this PR fixes:
Fixes #8686
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
The user can decide to enable admission plugin configuartion through
kube_apiserver_admission_control_config_file: true
and configure theEventRateLimit
using the following structure:Does this PR introduce a user-facing change?: