Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated openstack cloud controller version to v1.22.0 #8629

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Mar 17, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

To get some of the new features of the new cloud controller I updated the version of the openstack cloud controller to the current default kubernetes version.
The change should be transparent and not cause any changes to already running clusters.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

To update the manifests I used the upstream helm chart as inspiration.

Does this PR introduce a user-facing change?:

[OpenStack] Updated openstack cloud controller to version `v1.22.0`

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Xartos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2022
@Xartos
Copy link
Contributor Author

Xartos commented Mar 17, 2022

I just realized that the default kubernetes version is 1.23 (1.22 is the version in the latest release). However looking at the changelog reveales that ccm 1.23 has some breaking changes that might impact running instances. So maybe we're fine with only going to ccm v1.22

@@ -1,40 +0,0 @@
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach makes us loose the history of the file changes, is there a good reason to do this instead of modifying the file contents in-place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no particular reason other than that since it's only one object right now I thought it was unnecessary. But I can change back

@cristicalin
Copy link
Contributor

I just realized that the default kubernetes version is 1.23 (1.22 is the version in the latest release). However looking at the changelog reveales that ccm 1.23 has some breaking changes that might impact running instances. So maybe we're fine with only going to ccm v1.22

It is fine to stay with 1.22 if that avoids breaking changes but please update the PR title to reflect the change.

@Xartos Xartos changed the title Updated openstack cloud controller version to match kubernetes version Updated openstack cloud controller version to v1.22.0 Mar 17, 2022
@cristicalin
Copy link
Contributor

Thanks for the quick response @Xartos!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@oomichi
Copy link
Contributor

oomichi commented Mar 18, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@floryut floryut added kind/applications Applications section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi, Xartos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af7066d into kubernetes-sigs:master Mar 18, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
…s#8629)

* Updated openstack cloud controller version to match kubernetes version

* Rolled back file structure change
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
…s#8629)

* Updated openstack cloud controller version to match kubernetes version

* Rolled back file structure change
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
…s#8629)

* Updated openstack cloud controller version to match kubernetes version

* Rolled back file structure change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/applications Applications section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants