-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.18] nerdctl insecure registry config #8601
[2.18] nerdctl insecure registry config #8601
Conversation
Hi @tmurakam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle [2.18] nerdctl insecure registry config |
@tmurakam: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport kubernetes-sigs#8339 to 2.18-release Cherry-pick 24f1402
1933874
to
3027d03
Compare
Thanks for backporting. /ok-to-test |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, oomichi, tmurakam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tmurakam @cristicalin This PR as reverted part of 7fffe67 from #8380. A merge conflict was probably fixed too quickly. |
Signed-off-by: Mathieu Parent <[email protected]>
Signed-off-by: Mathieu Parent <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Backport #8339 to 2.18-release
Cherry-pick 24f1402
Which issue(s) this PR fixes:
Fixes #8339 on 2.18-release
Special notes for your reviewer:
Does this PR introduce a user-facing change?: