Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.18] nerdctl insecure registry config #8601

Conversation

tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Mar 4, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Backport #8339 to 2.18-release
Cherry-pick 24f1402

Which issue(s) this PR fixes:

Fixes #8339 on 2.18-release

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[containerd] nerdctl insecure registry support

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2022
@tmurakam tmurakam changed the title Backport #8339 to 2.18-release branch Backport #8339 (nerdctl insecure registry config) to 2.18-release branch Mar 4, 2022
@oomichi
Copy link
Contributor

oomichi commented Mar 5, 2022

/retitle [2.18] nerdctl insecure registry config

@k8s-ci-robot k8s-ci-robot changed the title Backport #8339 (nerdctl insecure registry config) to 2.18-release branch [2.18] nerdctl insecure registry config Mar 5, 2022
@k8s-ci-robot
Copy link
Contributor

@tmurakam: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmurakam tmurakam force-pushed the feature/backport-8339-to-2.18 branch from 1933874 to 3027d03 Compare March 6, 2022 12:02
@oomichi
Copy link
Contributor

oomichi commented Mar 7, 2022

Thanks for backporting.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2022
@cristicalin
Copy link
Contributor

/approve

1 similar comment
@oomichi
Copy link
Contributor

oomichi commented Mar 8, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, oomichi, tmurakam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0c43883 into kubernetes-sigs:release-2.18 Mar 8, 2022
@tmurakam tmurakam deleted the feature/backport-8339-to-2.18 branch March 8, 2022 23:14
@tmurakam tmurakam restored the feature/backport-8339-to-2.18 branch April 2, 2022 01:38
@sathieu
Copy link
Contributor

sathieu commented Apr 5, 2022

@tmurakam @cristicalin This PR as reverted part of 7fffe67 from #8380. A merge conflict was probably fixed too quickly.

sathieu added a commit to sathieu/kubespray that referenced this pull request Apr 5, 2022
k8s-ci-robot pushed a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants