Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable several read-only tasks in check mode #8584

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Enable several read-only tasks in check mode #8584

merged 1 commit into from
Mar 2, 2022

Conversation

tjanson
Copy link
Contributor

@tjanson tjanson commented Feb 28, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

(arguably feature, but IMHO any instance of breaking check mode is a bug)

What this PR does / why we need it:

This fixes several instances where check mode leads to undefined variable or attribute access errors or similar. (This is not hypothetical; each instance can cause execution failure in real usage.)

This PR is not intended to fix all errors of this class -- I'm sure there are plenty more. This allows check mode to succeed in some cases.

This vaguely relates to #8573, where check_mode: no caused unsafe code to run. This is the opposite case: code that is safe and required for further tasks and thus deserves check_mode: no.

Which issue(s) this PR fixes:

None. This is a very small step towards addressing:

Special notes for your reviewer:

I believe all changed tasks are safe, i.e., do not modify the target host, but by all means double-check.

Does this PR introduce a user-facing change?:

Enable several read-only tasks in check mode

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 28, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tjanson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2022
@tjanson tjanson force-pushed the missing-check-mode-no branch 2 times, most recently from 30a452c to f3bbbe2 Compare February 28, 2022 18:40
@tjanson
missing "check_mode: no"s for several read-only tasks
140d27c 
this is not complete -- there are almost certainly more instances of
this issue
@tjanson tjanson force-pushed the missing-check-mode-no branch from f3bbbe2 to 140d27c Compare February 28, 2022 18:42
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 28, 2022
floryut
floryut approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjanson Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, tjanson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 1, 2022
@floryut
Copy link
Member

floryut commented Mar 1, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 1, 2022
@cristicalin
Copy link
Contributor

Thanks @tjanson !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit ddef7e1 into kubernetes-sigs:master Mar 2, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@tjanson @sakuraiyuta
missing "check_mode: no"s for several read-only tasks (kubernetes-sig…
0b4f0bb 
…s#8584)

this is not complete -- there are almost certainly more instances of
this issue
@oomichi oomichi added the kind/bug Categorizes issue or PR as related to a bug. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
arno01 pushed a commit to arno01/kubespray that referenced this pull request Jul 19, 2022
@tjanson @arno01
missing "check_mode: no"s for several read-only tasks (kubernetes-sig…
7e13703 
…s#8584)

this is not complete -- there are almost certainly more instances of
this issue
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@tjanson @LuckySB
missing "check_mode: no"s for several read-only tasks (kubernetes-sig…
25dd1c6 
…s#8584)

this is not complete -- there are almost certainly more instances of
this issue
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 22, 2023
@tjanson @LuckySB
missing "check_mode: no"s for several read-only tasks (kubernetes-sig…
cb02c25 
…s#8584)

this is not complete -- there are almost certainly more instances of
this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjanson @k8s-ci-robot @floryut @cristicalin @oomichi