Prevent removing etcd member when running in check mode

[fungusakafungus]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes removing etcd node when running with --check. Before, running remove-node playbook on an etcd node with --check will happily remove the node. That's the opposite of how --check is supposed to work. This seems to be a copy-paste issue(introduced in https://github.com/kubernetes-sigs/kubespray/pull/5009/files#diff-84b588aaf686ff2f99d525c4269b48f766a3bc074f4cb34bd381918a43fb2ab1R23-R54), so I'm also removing other irrelevant lines.

Which issue(s) this PR fixes:

Special notes for your reviewer:
check_mode docs: https://docs.ansible.com/ansible/latest/user_guide/playbooks_checkmode.html#enforcing-or-preventing-check-mode-on-tasks

Does this PR introduce a user-facing change?:

Prevent removing etcd member when running in check mode

[k8s-ci-robot]

Hi @fungusakafungus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@fungusakafungus rofl.. that's a weird bug indeed :/

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, fungusakafungus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tjanson]

There's a similar issue in the etcd cert generation:

kubespray/roles/etcd/tasks/gen_certs_script.yml

Line 159 in e9c8913

check_mode: no

My guess is that that's just a copy and paste error from the task immediately above, where ignoring check mode makes sense.

I checked the rest of the codebase (searched via rg 'check_mode:..*(false|no)'), and these two places seem to be the only ones that are problematic (i.e. the remaining tasks only safely gather info).

[fungusakafungus]

There's a similar issue in the etcd cert generation:

I'll submit that fix separately

[cristicalin]

Weird bug indeed.
Good find @fungusakafungus !

/ok-to-test
/lgtm