Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform/gcp: Do not create unused subnetworks and Upgrade to latest google provider #8497

Merged
merged 2 commits into from
Feb 1, 2022
Merged

terraform/gcp: Do not create unused subnetworks and Upgrade to latest google provider #8497

merged 2 commits into from
Feb 1, 2022

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Jan 31, 2022 •
edited by oomichi
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

This PR has two changes:

  • Do not create unused subnetworks. Caught because I reached the maximun number of subnets (395)
  • Upgrade to latest google provider, caught by renovate

Which issue(s) this PR fixes:
Fixes #nope

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

terraform/gcp: Do not create unused subnetworks
terraform/gcp: Upgrade to latest google provider

@sathieu
terraform/gcp: Do not create unused subnetworks
dc5b2a6 
By default terraform creates a subnetwork in each 39 regions
@sathieu
terraform/gcp: Upgrade to latest google provider
8dcb07c 
... where "one of source_tags, source_ranges, or source_service_accounts must be defined"
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @sathieu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and jayonlau January 31, 2022 16:30
floryut
floryut approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
@sathieu Nice

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@oomichi
Copy link
Contributor

oomichi commented Feb 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 958bca8 into kubernetes-sigs:master Feb 1, 2022
@floryut floryut added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 2, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@sathieu @sakuraiyuta
terraform/gcp: Do not create unused subnetworks and Upgrade to latest…
517c731 
… google provider (kubernetes-sigs#8497)

* terraform/gcp: Do not create unused subnetworks

By default terraform creates a subnetwork in each 39 regions

* terraform/gcp: Upgrade to latest google provider

... where "one of source_tags, source_ranges, or source_service_accounts must be defined"
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@sathieu @LuckySB
terraform/gcp: Do not create unused subnetworks and Upgrade to latest…
3994ee5 
… google provider (kubernetes-sigs#8497)

* terraform/gcp: Do not create unused subnetworks

By default terraform creates a subnetwork in each 39 regions

* terraform/gcp: Upgrade to latest google provider

... where "one of source_tags, source_ranges, or source_service_accounts must be defined"
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 21, 2023
@sathieu @LuckySB
terraform/gcp: Do not create unused subnetworks and Upgrade to latest…
e41b2ba 
… google provider (kubernetes-sigs#8497)

* terraform/gcp: Do not create unused subnetworks

By default terraform creates a subnetwork in each 39 regions

* terraform/gcp: Upgrade to latest google provider

... where "one of source_tags, source_ranges, or source_service_accounts must be defined"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sathieu @k8s-ci-robot @oomichi @floryut