-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRI-O: fix unqualified-search registries #8496
CRI-O: fix unqualified-search registries #8496
Conversation
Hi @krystianmlynek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the commit. I tested your cleaner solution. It produces working config. |
@krystianmlynek Thanks for submitting this pull request. /ok-to-test |
@oomichi |
Thanks for updating. /lgtm |
Thanks @krystianmlynek /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, krystianmlynek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If we set
unqualified: true
incrio_registries:
e.g fordocker.io
playbook will fail and journalctl will show:With this change entries in
/etc/containers/registries.conf.d/01-unqualified.conf
are quoted. E.gunqualified-search-registries = ['docker.io']
Which issue(s) this PR fixes:
Fixes #8495
Special notes for your reviewer:
Does this PR introduce a user-facing change?: