Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding CoreDNS default zone cache block #8488

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Allow overriding CoreDNS default zone cache block #8488

merged 1 commit into from
Feb 1, 2022

Conversation

Tristan971
Copy link
Contributor

@Tristan971 Tristan971 commented Jan 30, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows overriding the CoreDNS cache plugin configuration for the default zone

Which issue(s) this PR fixes:
#8487

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[coredns] Allow overriding the default CoreDNS zone's `cache` plugin configuration via the `coredns_default_zone_cache_block` variable

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Tristan971!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Tristan971. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO January 30, 2022 03:40
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2022
@Tristan971 Tristan971 force-pushed the coredns_custom_cache_config branch 2 times, most recently from 34fbf2c to 4ee0215 Compare January 30, 2022 03:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2022
@Tristan971 Tristan971 force-pushed the coredns_custom_cache_config branch 3 times, most recently from 53ccf93 to f713713 Compare January 30, 2022 03:56
@Tristan971 Tristan971 changed the title Allow overriding CoreDNS cluster zone cache plugin block Allow overriding CoreDNS default zone cache block Jan 30, 2022
@Tristan971 Tristan971 force-pushed the coredns_custom_cache_config branch 5 times, most recently from 51303a4 to 524220b Compare January 30, 2022 04:28
@Tristan971
8487: Allow override of default CoreDNS zone cache
7389a0d 
Using the coredns_cluster_zone_cache_block variable
@Tristan971 Tristan971 force-pushed the coredns_custom_cache_config branch from 524220b to 7389a0d Compare January 30, 2022 04:33
@Tristan971
Copy link
Contributor Author

/assign @woopstar

@liupeng0518
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2022
@Tristan971
Copy link
Contributor Author

Afaict the 3 failed tests are unrelated; should I ping Florian on slack or can a passerby kick them?

@floryut
Copy link
Member

floryut commented Jan 31, 2022

Afaict the 3 failed tests are unrelated; should I ping Florian on slack or can a passerby kick them?

Fastest thing to do is to ping someone on the #kubespray-dev channel indeed 😄
(I've retried it)

@woopstar
Copy link
Member

woopstar commented Feb 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@woopstar
Copy link
Member

woopstar commented Feb 1, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
floryut
floryut approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tristan971 Thank you 👍 (and thanks for the doc!)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Tristan971, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 92d612c into kubernetes-sigs:master Feb 1, 2022
@Tristan971 Tristan971 deleted the coredns_custom_cache_config branch February 1, 2022 08:49
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@Tristan971 @sakuraiyuta
8487: Allow override of default CoreDNS zone cache (kubernetes-sigs#8488
3052b7a 
)

Using the coredns_cluster_zone_cache_block variable
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@Tristan971 @LuckySB
8487: Allow override of default CoreDNS zone cache (kubernetes-sigs#8488
f23b1f2 
)

Using the coredns_cluster_zone_cache_block variable
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@Tristan971 @LuckySB
8487: Allow override of default CoreDNS zone cache (kubernetes-sigs#8488
631bea8 
)

Using the coredns_cluster_zone_cache_block variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tristan971 @k8s-ci-robot @liupeng0518 @floryut @woopstar