-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reset] remove containerd storage during reset #8469
[reset] remove containerd storage during reset #8469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
roles/reset/tasks/main.yml
Outdated
@@ -264,6 +264,8 @@ | |||
with_items: | |||
- "{{ kube_config_dir }}" | |||
- /var/lib/kubelet | |||
- /var/lib/containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"{{ containerd_storage_dir }}"
can be used instead for specifying the other value than the default /var/lib/containerd
.
roles/reset/tasks/main.yml
Outdated
@@ -264,6 +264,8 @@ | |||
with_items: | |||
- "{{ kube_config_dir }}" | |||
- /var/lib/kubelet | |||
- /var/lib/containerd | |||
- /var/lib/etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"{{ etcd_data_dir }}"
is specified already at the original line 269.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristicalin: GitHub didn't allow me to request PR reviews from the following users: wirwolf. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8fa0aea
to
29caab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for updating. /lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
When we reset the cluster state we should ensure
/var/lib/containerd
is also properly cleaned up.Which issue(s) this PR fixes:
Fixes #8449
Special notes for your reviewer:
Does this PR introduce a user-facing change?: