Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reset] remove containerd storage during reset #8469

Merged

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Jan 25, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
When we reset the cluster state we should ensure /var/lib/containerd is also properly cleaned up.

Which issue(s) this PR fixes:

Fixes #8449

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[reset] remove containerd storage during reset

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2022
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

@@ -264,6 +264,8 @@
with_items:
- "{{ kube_config_dir }}"
- /var/lib/kubelet
- /var/lib/containerd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"{{ containerd_storage_dir }}" can be used instead for specifying the other value than the default /var/lib/containerd.

@@ -264,6 +264,8 @@
with_items:
- "{{ kube_config_dir }}"
- /var/lib/kubelet
- /var/lib/containerd
- /var/lib/etcd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"{{ etcd_data_dir }}" is specified already at the original line 269.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, indeed, then I wonder what were the specific conditions in #8449 where it did not get removed.

/cc @wirwolf

@k8s-ci-robot k8s-ci-robot requested a review from oomichi January 26, 2022 01:40
@k8s-ci-robot
Copy link
Contributor

@cristicalin: GitHub didn't allow me to request PR reviews from the following users: wirwolf.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Hmm, indeed, then I wonder what were the specific conditions in #8449 where it did not get removed.

/cc @wirwolf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cristicalin cristicalin force-pushed the reset_etcd_containerd branch from 8fa0aea to 29caab0 Compare January 26, 2022 06:35
@cristicalin cristicalin changed the title [reset] remove /var/lib/containerd and /var/lib/etcd on reset [reset] remove containerd storage during reset Jan 26, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 26, 2022

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 26a5948 into kubernetes-sigs:master Jan 26, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all additional data in reset stage
4 participants