Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert-manager: Allow to change leader election namespace for GKE Autopilot support #8424

Merged
merged 1 commit into from
Jan 14, 2022
Merged

cert-manager: Allow to change leader election namespace for GKE Autopilot support #8424

merged 1 commit into from
Jan 14, 2022

Conversation

rtsp
Copy link
Member

@rtsp rtsp commented Jan 13, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8393

Special notes for your reviewer:

Tested on my cluster

Does this PR introduce a user-facing change?:

Allow to change cert-manager leader election namespace for GKE Autopilot support

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rtsp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi January 13, 2022 20:13
@rtsp rtsp force-pushed the develop/8393-cert-manager-gke-autopilot branch from 6bb9956 to 041ba01 Compare January 13, 2022 20:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2022
@rtsp rtsp marked this pull request as ready for review January 13, 2022 20:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2022
@cristicalin
Copy link
Contributor

@rtsp thanks for this fix!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 14, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit ccd3180 into kubernetes-sigs:master Jan 14, 2022
This was referenced Jan 15, 2022
Closed
Merged
Closed
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 17, 2022
rtsp added a commit to rtsp/kubespray that referenced this pull request Apr 4, 2022
@rtsp
[2.18] cert-manager: Backport cert-manager leader election namespace …
0b42623 
…fixes from master

- cert-manager: Fix incorrect leader election namespace lead to insufficient permission (kubernetes-sigs#8433)
- cert-manager: Allow to change leader election namespace for GKE Autopilot support (kubernetes-sigs#8424)
rtsp added a commit to rtsp/kubespray that referenced this pull request Apr 4, 2022
@rtsp
[2.18] cert-manager: Backport cert-manager leader election namespace …
7d52188 
…fixes from master

cherry-picked from
* ccd3180 cert-manager: Fix incorrect leader election namespace lead to insufficient permission (kubernetes-sigs#8433)
* e791089 cert-manager: Allow to change leader election namespace for GKE Autopilot support (kubernetes-sigs#8424)
@rtsp rtsp mentioned this pull request Apr 4, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Apr 4, 2022
@rtsp
[2.18] cert-manager: Backport cert-manager leader election namespace …
58bea67 
…fixes from master (#8681)

cherry-picked from
* ccd3180 cert-manager: Fix incorrect leader election namespace lead to insufficient permission (#8433)
* e791089 cert-manager: Allow to change leader election namespace for GKE Autopilot support (#8424)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@rtsp @sakuraiyuta
cert-manager: Allow to change leader election namespace for GKE Autop…
cb868c2 
…ilot support (kubernetes-sigs#8424)

More information:

- kubernetes-sigs#8393
- cert-manager/cert-manager#4102
- cert-manager/cert-manager#3717
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@rtsp @LuckySB
cert-manager: Allow to change leader election namespace for GKE Autop…
eadd391 
…ilot support (kubernetes-sigs#8424)

More information:

- kubernetes-sigs#8393
- cert-manager/cert-manager#4102
- cert-manager/cert-manager#3717
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@rtsp @LuckySB
cert-manager: Allow to change leader election namespace for GKE Autop…
d772c78 
…ilot support (kubernetes-sigs#8424)

More information:

- kubernetes-sigs#8393
- cert-manager/cert-manager#4102
- cert-manager/cert-manager#3717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cert-manager fails to work correctly due to insufficient permissions on v2.18.0
5 participants
@rtsp @k8s-ci-robot @cristicalin @oomichi @floryut