Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.18] Fix container engine still installed on dedicated etcd #8404

Merged
merged 1 commit into from
Jan 11, 2022
Merged

[2.18] Fix container engine still installed on dedicated etcd #8404

merged 1 commit into from
Jan 11, 2022

Conversation

rtsp
Copy link
Member

@rtsp rtsp commented Jan 11, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backport of #8386 to release-2.18 branch

Which issue(s) this PR fixes:
Fixes #7987
Fixes #8381

Special notes for your reviewer:

  • Open discussion. I'm not sure if we should backport this PR or just wait for 2.18.1 release.

Does this PR introduce a user-facing change?:

Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host`

@rtsp
[2.18] Fix container engine still installed on dedicated etcd
11ca654 
* Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host` (kubernetes-sigs#8386)

(cherry picked from commit aa4a3d7)
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rtsp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi January 11, 2022 00:00
@oomichi
Copy link
Contributor

oomichi commented Jan 11, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8a3c78e into kubernetes-sigs:release-2.18 Jan 11, 2022
@rtsp rtsp mentioned this pull request Jan 15, 2022
Closed
7 tasks
huangkevin404 pushed a commit to wiremind/kubespray that referenced this pull request Sep 15, 2022
@rtsp
[2.18] Fix container engine still installed on dedicated etcd (kubern…
b8cfa52 
…etes-sigs#8404)

* Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host` (kubernetes-sigs#8386)

(cherry picked from commit aa4a3d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtsp @k8s-ci-robot @oomichi @floryut