Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crun update to 1.4 #8330

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

cristicalin
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds support for crun 1.4 and drops support for pre-1.x versions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Since this drops some support and crun is not really a first-class citizen in kubespray I submit this but propose to keep it for post 2.18.

Does this PR introduce a user-facing change?:

[crun] update to 1.4 and drop pre-1.x versions

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2021
@cristicalin
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO December 22, 2021 18:51
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post 2.18, here we are!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@cristicalin
Copy link
Contributor Author

/hold cancel

\o/

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@floryut
Copy link
Member

floryut commented Jan 4, 2022

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi January 4, 2022 16:21
@oomichi
Copy link
Contributor

oomichi commented Jan 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2022
@floryut floryut added kind/container-managers Containers section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jan 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4c4c83f into kubernetes-sigs:master Jan 4, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* [crun] update crun to 1.4

* [crun] drop pre-1.x versions
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
* [crun] update crun to 1.4

* [crun] drop pre-1.x versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants