Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameterized snaphot controller namespaces #8305

Merged
merged 4 commits into from
Jan 14, 2022
Merged

parameterized snaphot controller namespaces #8305

merged 4 commits into from
Jan 14, 2022

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented Dec 13, 2021 •
edited by oomichi
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

parameterized snaphot controller namespaces

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow the customization of snapshot controller namespace using `snapshot_controller_namespace`

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO December 13, 2021 11:09
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2021
@cristicalin
Copy link
Contributor

Great idea @liupeng0518 ! Could you also add a node in our docs about the new variable and when deployers might want to change the default?

@liupeng0518
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2021
@floryut
Copy link
Member

floryut commented Jan 5, 2022

/hold

why is this one on hold ?

@cristicalin
Copy link
Contributor

ping @liupeng0518

Is this still relevant to remove the hold and merge it?

@liupeng0518
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@liupeng0518
Copy link
Member Author

Great idea @liupeng0518 ! Could you also add a node in our docs about the new variable and when deployers might want to change the default?

done

@liupeng0518 liupeng0518 force-pushed the Parameterized-namespaces branch from e3de189 to 34a6d5b Compare January 13, 2022 01:15
@liupeng0518
Copy link
Member Author

@cristicalin @floryut

@cristicalin
Copy link
Contributor

I'm somewhat conflicted by the fact that we are missing a document to describe general storage considerations where we could add a point about this feature but it's unreasonable to ask to start one in this PR so ...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 14, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liupeng0518, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1a69f8c into kubernetes-sigs:master Jan 14, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@liupeng0518 @sakuraiyuta
parameterized snaphot controller namespaces (kubernetes-sigs#8305)
690ec5b 
* Parameterized snaphot controller namespaces

* add ns yml

* add docs

* namespace
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@liupeng0518 @LuckySB
parameterized snaphot controller namespaces (kubernetes-sigs#8305)
a6501de 
* Parameterized snaphot controller namespaces

* add ns yml

* add docs

* namespace
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@liupeng0518 @LuckySB
parameterized snaphot controller namespaces (kubernetes-sigs#8305)
5d12c15 
* Parameterized snaphot controller namespaces

* add ns yml

* add docs

* namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liupeng0518 @cristicalin @floryut @oomichi @k8s-ci-robot