Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico: Add kube_service_addresses_ipv6 to serviceClusterIPs #7944

Conversation

olemathias
Copy link
Contributor

Add IPv6 Service Addresses to BGP advertisement when calico_advertise_cluster_ips is true.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently when enabling calico_advertise_cluster_ips only IPv4 kube_service_addresses is added. This PR also adds IPv6 kube_service_addresses_ipv6 when enable_dual_stack_networks is true.

Which issue(s) this PR fixes:
Fixes #7889

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Calico: kube_service_addresses_ipv6 is now added to serviceClusterIPs if enable_dual_stack_networks is true.

…tes-sigs#7889)

Add IPv6 Service Addresses to BGP advertisement when 
calico_advertise_cluster_ips is true.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @olemathias!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @olemathias. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO September 6, 2021 21:10
@olemathias olemathias changed the title Calico: Add kube_service_addresses_ipv6 to serviceClusterIPs (#7889) Calico: Add kube_service_addresses_ipv6 to serviceClusterIPs Sep 6, 2021
@@ -240,7 +240,8 @@
"logSeverityScreen": "Info",
{% if not calico_no_global_as_num|default(false) %}"asNumber": {{ global_as_num }},{% endif %}
"nodeToNodeMeshEnabled": {{ nodeToNodeMeshEnabled|default('true') }} ,
{% if calico_advertise_cluster_ips|default(false) %}"serviceClusterIPs": [{"cidr": "{{ kube_service_addresses }}" }],{% endif %}
{% if calico_advertise_cluster_ips|default(false) %}
"serviceClusterIPs": [{"cidr": "{{ kube_service_addresses }}" } {{ ',{"cidr":"' + kube_service_addresses_ipv6 + '"}' if enable_dual_stack_networks else '' }}],{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.projectcalico.org/networking/advertise-service-ips#advertise-service-cluster-ip-addresses this option seems good.
In addition, this kube_service_addresses_ipv6 is available only if enable_dual_stack_networks is true on Kubespray side.
That also looks good for me because of the following description:

# Kubernetes internal network for IPv6 services, unused block of space.
# This is only used if enable_dual_stack_networks is set to true
# This provides 4096 IPv6 IPs
kube_service_addresses_ipv6: fd85:ee78:d8a6:8607::1000/116

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@oomichi
Copy link
Contributor

oomichi commented Sep 7, 2021

forgot to put ok-to-test..

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@floryut
Copy link
Member

floryut commented Sep 8, 2021

@olemathias Thanks for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, olemathias

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 69b67a2 into kubernetes-sigs:master Sep 8, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
…tes-sigs#7889) (kubernetes-sigs#7944)

Add IPv6 Service Addresses to BGP advertisement when 
calico_advertise_cluster_ips is true.
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
…tes-sigs#7889) (kubernetes-sigs#7944)

Add IPv6 Service Addresses to BGP advertisement when 
calico_advertise_cluster_ips is true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calico - IPv6 Service Addresses missing from BGP advertisement
4 participants