Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSI snaphotter and make it independent #7943

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Update CSI snaphotter and make it independent #7943

merged 4 commits into from
Sep 6, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Sep 5, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Some CSI drivers which are not currently part of kubespray require the CSI snapshot controller (i.e. Rancher Longhorn). We currently support this snapshot controller in kubespray but it is outdated and tied to the cinder csi driver. This PR brings in the latest CSI snapshot controller and allows deploying the snapshotter without any dependency on other CSI drivers like cinder.

The 4.2.0 release of the external snapshotter is only compatible with kubernetes 1.20 and above. For kubernetes 1.19 we deploy with version 4.0.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CSI: update CSI snapshotter and allow enabling it stand-alone

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2021
@cristicalin cristicalin marked this pull request as draft September 5, 2021 15:41
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2021
@cristicalin cristicalin force-pushed the csi_snapshotter_update branch from 30fb180 to 1fa5592 Compare September 5, 2021 15:54
@cristicalin cristicalin force-pushed the csi_snapshotter_update branch from 1fa5592 to f71a4dc Compare September 5, 2021 16:07
@cristicalin cristicalin marked this pull request as ready for review September 5, 2021 16:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2021
@cristicalin cristicalin force-pushed the csi_snapshotter_update branch from f71a4dc to 92a23b9 Compare September 6, 2021 06:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2021
@alijahnas
Copy link
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit db470f8 into kubernetes-sigs:master Sep 6, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
Closed
@D3DeFi D3DeFi mentioned this pull request Sep 20, 2021
Closed
@cristicalin cristicalin mentioned this pull request Oct 12, 2021
Closed
7 tasks
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@cristicalin @LuckySB
Update CSI snaphotter and make it independent (kubernetes-sigs#7943)
9c291f5 
* CSI: update CSI snapshot CRDs

* CSI: update snapshot controller tag version with kubernetes specific versions

* CSI: allow enabling csi_snapshot_controller independent of Cinder CSI

* CSI: Align csi-snapshot-controller with upstream and use a Deployment instead of a StatefulSet
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Update CSI snaphotter and make it independent (kubernetes-sigs#7943)
f626a05 
* CSI: update CSI snapshot CRDs

* CSI: update snapshot controller tag version with kubernetes specific versions

* CSI: allow enabling csi_snapshot_controller independent of Cinder CSI

* CSI: Align csi-snapshot-controller with upstream and use a Deployment instead of a StatefulSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@alijahnas alijahnas Awaiting requested review from alijahnas

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@alijahnas alijahnas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristicalin @k8s-ci-robot @alijahnas @floryut