Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico: replace version 3.19.1 with 3.19.2 and set default #7867

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Calico: replace version 3.19.1 with 3.19.2 and set default #7867

merged 1 commit into from
Aug 25, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Aug 10, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Calico released 3.19.2 as a bugfix release. See https://docs.projectcalico.org/archive/v3.19/release-notes/ for details. Given that we added 3.20.0 hashes in #7855 , this PR also bumps the default calico_version to 3.19.2.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Calico: bump 3.19.1 to 3.19.2

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2021
@oomichi
Copy link
Contributor

oomichi commented Aug 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021
@cristicalin cristicalin mentioned this pull request Aug 10, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2021
@cristicalin
Calico: replace version 3.19.1 with 3.19.2 and set as default
9407348 
Bump calico version to 3.19.2 due to adding 3.20.0 earlier
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2021
@floryut floryut changed the title Calico: replace version 3.19.1 with 3.19.2 Calico: replace version 3.19.1 with 3.19.2 and set default Aug 12, 2021
floryut
floryut approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristicalin Great, thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@oomichi
Copy link
Contributor

oomichi commented Aug 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit f66c49b into kubernetes-sigs:master Aug 25, 2021
notCalle added a commit to notCalle/kubespray that referenced this pull request Sep 7, 2021
@notCalle
Update calico 3.17.4 → .5
c9c0494 
Calico: add support for v3.19.1 (kubernetes-sigs#7630)

* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default

Calico: upgrade 3.18 to 3.18.4 (kubernetes-sigs#7648)

Calico: add v3.20.0 hashes (kubernetes-sigs#7855)

Calico: replace version 3.19.1 with 3.19.2 and set as default (kubernetes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier

Calico: replace hashes for latest 3.17 and 3.18 to the .5 minor versions (kubernetes-sigs#7924)
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Sep 7, 2021
@cristicalin @notCalle
Calico: replace version 3.19.1 with 3.19.2 and set as default (kubern…
c12c1aa 
…etes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@cristicalin @LuckySB
Calico: replace version 3.19.1 with 3.19.2 and set as default (kubern…
bd66540 
…etes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Dec 22, 2021
@cristicalin @notCalle
Calico: replace version 3.19.1 with 3.19.2 and set as default (kubern…
7410f60 
…etes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Calico: replace version 3.19.1 with 3.19.2 and set as default (kubern…
be2a776 
…etes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristicalin @k8s-ci-robot @oomichi @floryut