Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vSphere CPI ClusterRole and docs #7838

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Update vSphere CPI ClusterRole and docs #7838

merged 1 commit into from
Jul 30, 2021

Conversation

vi7
Copy link
Contributor

@vi7 vi7 commented Jul 29, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

  • vSphere CPI ClusterRole updated according to the latest official CPI manifests
  • vSphere CPI/CSI default versions bumped and tested successfully on K8S 1.21.1
  • vSphere documentation updated

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update vSphere CPI ClusterRole according to the latest [official CPI manifests](https://github.com/kubernetes/cloud-provider-vsphere/tree/master/manifests/controller-manager)

@vi7
Update vSphere CPI
124f0a1 
  Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vi7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten July 29, 2021 12:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2021
floryut
floryut approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, vi7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@oomichi
Copy link
Contributor

oomichi commented Jul 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5db86f4 into kubernetes-sigs:master Jul 30, 2021
@vi7 vi7 deleted the update_vsphere_cpi_role branch July 30, 2021 07:50
vi7 added a commit to vi7/kubespray that referenced this pull request Jul 30, 2021
@vi7
Update vSphere CPI
1b2f995 
Backport of kubernetes-sigs#7838

Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
vi7 added a commit to vi7/kubespray that referenced this pull request Jul 30, 2021
@vi7
Update vSphere CPI
acb265b 
Backport of kubernetes-sigs#7838

Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
@vi7 vi7 mentioned this pull request Jul 30, 2021
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jul 30, 2021
@vi7
Update vSphere CPI (#7840)
713abf2 
Backport of #7838

Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
rtsp pushed a commit to rtsp/kubespray that referenced this pull request Jul 30, 2021
@vi7 @rtsp
Update vSphere CPI (kubernetes-sigs#7840)
45b90cb 
Backport of kubernetes-sigs#7838

Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
Quehenr added a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Aug 2, 2021
@Quehenr
Merge branch 'master' into feature/virtualbox
474597b 
* master: (23 commits)
  retry to fetch binary if it fails first time (kubernetes-sigs#7839)
  Update vSphere CPI (kubernetes-sigs#7838)
  doc: Update 'Kubespray vs Kubeadm' (kubernetes-sigs#7834)
  Update MetalLB documentation (kubernetes-sigs#7833)
  Disable OVH CI until  voucher situation is cleared up (kubernetes-sigs#7824)
  Fix how to get image ID on offline deployment (kubernetes-sigs#7808)
  CRI-O: Install libseccomp2 from backports on Debian 10 (kubernetes-sigs#7816)
  fix(misc): contrib/terraform/aws (kubernetes-sigs#7818)
  Separate gvisor_download_url for runsc and shim (kubernetes-sigs#7760)
  Allow failure on tf-elax_ubuntu18-calico (kubernetes-sigs#7814)
  Add containerd on Flatcar Container Linux (kubernetes-sigs#7681)
  Fixup label for oracle linux bootstrap
  Update multus to 3.7.2 (and move to ghcr.io)
  Set default k8s version to 1.21.3
  Add hashes for k8s 1.20.8/.9 and 1.19.12/.13 and 1.21.3
  Fix erroneous ansible args
  Update kube-router to 1.3.0
  Update flannel to 0.14.0 (moved from coreos repo to flannel-io)
  Use dashboard 2.3.1 image
  Set Helm default version to 3.6.3
  ...
@floryut floryut mentioned this pull request Sep 8, 2021
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@vi7 @LuckySB
Update vSphere CPI (kubernetes-sigs#7838)
ac83eef 
Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@vi7 @sakuraiyuta
Update vSphere CPI (kubernetes-sigs#7838)
5ebe02c 
Changes:
  * ClusterRole updated according to the latest manifests from
    https://github.com/kubernetes/cloud-provider-vsphere
  * vSphere CPI/CSI default versions bumped and
    tested successfully on K8S 1.21.1
  * vSphere documentation updated

Signed-off-by: Vitaliy D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vi7 @k8s-ci-robot @oomichi @floryut