Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add containerd on fedora CoreOS #7794

Merged
merged 6 commits into from
Jul 15, 2021
Merged

add containerd on fedora CoreOS #7794

merged 6 commits into from
Jul 15, 2021

Conversation

spaced
Copy link
Contributor

@spaced spaced commented Jul 11, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • enable containerd on fedora CoreOS
  • remove workaround for older fcos versions
  • fixes bug with crio
  • update docs

Which issue(s) this PR fixes:
Fixes #7793

Special notes for your reviewer:
fcos runs with cgroupv2, no issues found so far
selinux enforcing would work too, but in docs it seams to be not supported?

Does this PR introduce a user-facing change?:

Enable containerd on Fedora CoreOS

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi July 11, 2021 10:38
@k8s-ci-robot
Copy link
Contributor

Hi @spaced. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2021
@spaced spaced changed the title Fcos cleanup add containerd fedora CoreOS Jul 11, 2021
@spaced spaced changed the title add containerd fedora CoreOS add containerd on fedora CoreOS Jul 11, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 12, 2021
floryut
floryut approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/hold needs #7791

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, spaced

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@oomichi
Copy link
Contributor

oomichi commented Jul 13, 2021

The corresponding pull request is merged, so can we unhold this pr?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@spaced
Copy link
Contributor Author

spaced commented Jul 14, 2021

should i rebase?

@jayonlau
Copy link
Contributor

lgtm

1 similar comment
@jayonlau
Copy link
Contributor

lgtm

@floryut
Copy link
Member

floryut commented Jul 15, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@floryut
Copy link
Member

floryut commented Jul 15, 2021

should i rebase?

nop all good, it was just that your PR included your commit from the other one 👍

@k8s-ci-robot k8s-ci-robot merged commit c2cf0d9 into kubernetes-sigs:master Jul 15, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@spaced @LuckySB
add containerd on fedora CoreOS (kubernetes-sigs#7794)
333be3c 
* set selinux type t_etc if selinux state is enforcing

* workaround with update repo is no longer needed
remove comments about failing playbook

* grubby is not available in distros using ostree

* remove docker support because removed in fcos
update install script example with live rootfs

* do not call grubby on ostree based distro

* update docs enabling containerd on fedora coreos
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@spaced @sakuraiyuta
add containerd on fedora CoreOS (kubernetes-sigs#7794)
2150f4f 
* set selinux type t_etc if selinux state is enforcing

* workaround with update repo is no longer needed
remove comments about failing playbook

* grubby is not available in distros using ostree

* remove docker support because removed in fcos
update install script example with live rootfs

* do not call grubby on ostree based distro

* update docs enabling containerd on fedora coreos
@spaced spaced deleted the fcos_cleanup branch June 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster playbook fails using fedora coreos with crio
5 participants
@spaced @k8s-ci-robot @oomichi @jayonlau @floryut