Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Graceful Node Shutdown for Kubernetes >= 1.21.0 #7746

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Enable Graceful Node Shutdown for Kubernetes >= 1.21.0 #7746

merged 2 commits into from
Jun 28, 2021

Conversation

cristicalin
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
Kubernetes 1.21 enables the Graceful Node Shutdown beta feature by default. This PR enables this feature by configuring the two parameters needed to properly set it up. For details see https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/

Which issue(s) this PR fixes:

Fixes #7732

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable Graceful Node Shutdown for Kubernetes >= 1.21.0

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 25, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi June 25, 2021 11:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2021
@champtar
Copy link
Contributor

/lgtm
Thanks for working on this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@oomichi
Copy link
Contributor

oomichi commented Jun 25, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2021
floryut
floryut approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @cristicalin

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit a3e34f5 into kubernetes-sigs:master Jun 28, 2021
@champtar
Copy link
Contributor

champtar commented Aug 2, 2021

Haven't tried this yet, but we might need some systemd config: https://blog.skouf.com/posts/enabling-graceful-node-shutdown-on-eks-in-kubernetes-1-21/

@floryut floryut mentioned this pull request Sep 8, 2021
Closed
@champtar champtar mentioned this pull request Sep 20, 2021
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@cristicalin @LuckySB
Enable Graceful Node Shutdown for Kubernetes >= 1.21.0 (kubernetes-si…
d22bf9c 
…gs#7746)

* Enable Graceful Node Shutdown for Kubernetes >= 1.21.0

* Add sample graceful shutdown parameters
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Enable Graceful Node Shutdown for Kubernetes >= 1.21.0 (kubernetes-si…
ec3176c 
…gs#7746)

* Enable Graceful Node Shutdown for Kubernetes >= 1.21.0

* Add sample graceful shutdown parameters
@rptaylor
Copy link
Contributor

This is causing problems in production similar to kubernetes/kubernetes#106292 noted by @champtar . It looks like there is no kubespray option to disable this feature.

@champtar
Copy link
Contributor

@rptaylor This issue is fixed in 1.23+

@Danozavr
Copy link

Danozavr commented Dec 4, 2024

It seems to me that it needs some improvement, since on some systems there is a restriction on inhibit, such as in Ubuntu 20.04. Or at least add a link to an article on setting up the systemd in the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@champtar champtar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Graceful Node Shutdown by default (k8s 1.21+)
7 participants
@cristicalin @k8s-ci-robot @champtar @oomichi @rptaylor @Danozavr @floryut