-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove environment variable in remove-node play #7729
Conversation
Welcome @sdd1798! |
Hi @sdd1798. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
Please update the title based on current change and squash current 2 commits into a single commit to avoid confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Please check again CLA with email acc use in commit
@sdd1798 Do you have time to handle the fixup ? (and cla check) |
Please check your email addresses are the same on both commit author and CLA registered one. /lgtm |
We may wait a bit but I guess we won't have any other choice than cloning the PR. |
I signed it |
Oops! Missed it. Now done! @floryut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great thanks @sdd1798 !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, sdd1798 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: Remove environment variable in remove-node play (kubernetes-sigs#7729)
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes following error
"The error was: 'proxy_disable_env' is undefined\n" in remove-node.yaml
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: