fix image pull url for coredns v1.8.0 #7702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/cc @floryut |
oomichi
reviewed
Jun 16, 2021
|
|
||
| coredns_version: "v1.8.0" | ||
| coredns_image_is_namespaced: "{{ (kube_version is version('v1.21.0','>=')) or (coredns_version is version('v1.7.1','>=')) }}" |
There was a problem hiding this comment.
The linked discussion shows the subpath depends on coredns_version(v1.7.1+).
Why here needs to depend on kube_version also?
There was a problem hiding this comment.
ah, that is for the existing commit a0ee569
It seems fine to keep here.
k8s-ci-robot
added
the
lgtm
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last version v1.7.0 was not yet using a subpath due to it using the legacy promotion.
now have a subpath so it should be available under k8s.gcr.io/coredns/coredns:v1.8.0 and k8s.gcr.io/coredns/coredns:v1.7.1.
kubernetes/k8s.io#1405 (comment)
What type of PR is this?
/kind bug