Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #7573 - Made Calico permissions compatible with v3.18.x #7575

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

holmesb
Copy link
Contributor

@holmesb holmesb commented Apr 29, 2021

See projectcalico/calico#4557. Specifically, granted watch to custom resources: blockaffinities, ipamblocks & ipamhandles.

What type of PR is this?

/kind bug

What this PR does / why we need it:
Existing permissions cause a "connection is unauthorized" message to be logged many times per second by pod: kube-system/calico-kube-controllers

Which issue(s) this PR fixes:
Fixes #7573

Does this PR introduce a user-facing change?:

NONE

… with v3.18.x (see projectcalico/calico#4557).  Specifically, granted watch to custom resources blockaffinities, ipamblocks & ipamhandles
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @holmesb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO April 29, 2021 16:25
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2021
@floryut
Copy link
Member

floryut commented Apr 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, holmesb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@champtar
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3f4eb9b into kubernetes-sigs:master Apr 30, 2021
unai-ttxu pushed a commit to unai-ttxu/kubespray that referenced this pull request May 18, 2021
… with v3.18.x (see projectcalico/calico#4557).  Specifically, granted watch to custom resources blockaffinities, ipamblocks & ipamhandles (kubernetes-sigs#7575)
unai-ttxu added a commit to Stratio/kubespray that referenced this pull request May 18, 2021
* Add Calico v3.17.3 and v3.18.1 (kubernetes-sigs#7524)

* add hashes for calico v3.17.3

* add hashes for claico v3.18.1

* bump default calico version to v3.17.3

* calico crds are missing yaml separator breaking kdd

* Calico new versions v3.17.4 and v3.18.2 (kubernetes-sigs#7563)

* calico: upgrade from v3.17.3 to v3.17.4

* calico: upgrade from v3.18.1 to v3.18.2

* Fixes issue kubernetes-sigs#7573 - Made Calico permissions compatible with v3.18.x (see projectcalico/calico#4557).  Specifically, granted watch to custom resources blockaffinities, ipamblocks & ipamhandles (kubernetes-sigs#7575)

* bump calico 3.18 to v3.18.3 (kubernetes-sigs#7592)

* Support Calico advertisement of MetalLB LoadBalancer IPs (kubernetes-sigs#7593)

* add initial MetalLB docs

* metallb allow disabling the deployment of the metallb speaker

* calico>=3.18 allow using calico to advertise service loadbalancer IPs

* Document the use of MetalLB and Calico

* clean MetalLB docs

Co-authored-by: Cristian Calin <[email protected]>
Co-authored-by: holmesb <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 12, 2021
… with v3.18.x (see projectcalico/calico#4557).  Specifically, granted watch to custom resources blockaffinities, ipamblocks & ipamhandles (kubernetes-sigs#7575)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
… with v3.18.x (see projectcalico/calico#4557).  Specifically, granted watch to custom resources blockaffinities, ipamblocks & ipamhandles (kubernetes-sigs#7575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix permissions in Calico v3.18.x
4 participants