change kubeadm coredns addon images name to `coredns/coredns` #7570

MRoci · 2021-04-28T15:52:25Z

What type of PR is this?

/kind bug

What this PR does / why we need it:
at the moment kubeadm has hardcoded that the name of the coreDNS image
is coredns/coredns.
When using k8s.gcr.io as image repository this is false for versions
<=1.7.0 which are located at k8s.gcr.io/coredns:${VERSION}.
This causes the deployment to be unable to pull images until the
kubernetes-apps role ovverrides it with the correct image location

docker.io fullfills the assumptions made by kubeadm that the image is
found under the name coredns/coredns

Also on gcr.io newest tags such as +1.8.0 seems not to be available at
the moment, making impossible to upgrade the coredns component

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2021-04-28T15:52:32Z

Welcome @MRoci!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-04-28T15:52:33Z

Hi @MRoci. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MRoci · 2021-04-28T16:02:21Z

/assign @mirwan

floryut

/ok-to-test

I was the one that switch this one to k8s.gcr.io when we had everything in dockerhub and they added a limit.. but you're right as it's not even up to date with 1.21 default (1.8.0) 😢

k8s-ci-robot · 2021-04-28T16:14:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MRoci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tvanderka · 2021-04-28T23:11:40Z

This PR sets kubeadm 1.20 config pointing to docker.io/coredns:1.7.0 which is wrong. Kubeadm switched to coredns/coredns in 1.21, for coredns v1.8.0 (note the "v", you can also pull "k8s.gcr.io/coredns/coredns:v1.7.0"). No need to switch to docker.io

See kubernetes/kubernetes#101300

muzi502 · 2021-04-29T02:45:07Z

This PR sets kubeadm 1.20 config pointing to docker.io/coredns:1.7.0 which is wrong. Kubeadm switched to coredns/coredns in 1.21, for coredns v1.8.0 (note the "v", you can also pull "k8s.gcr.io/coredns/coredns:v1.7.0"). No need to switch to docker.io

See kubernetes/kubernetes#101300

You are right, should use k8s.gcr.io/coredns/coredns begin v1.21

These are coredns's tag in different image repo :

k8s.gcr.io/coredns/coredns

root@debian:/root # skopeo list-tags docker://k8s.gcr.io/coredns/coredns
{
    "Repository": "k8s.gcr.io/coredns/coredns",
    "Tags": [
        "v1.6.6",
        "v1.6.7",
        "v1.6.9",
        "v1.7.0",
        "v1.7.1",
        "v1.8.0",
        "v1.8.3"
    ]
}

k8s.gcr.io/coredns

root@debian:/root # skopeo list-tags docker://k8s.gcr.io/coredns
{
    "Repository": "k8s.gcr.io/coredns",
    "Tags": [
        "1.0.1",
        "1.0.1__amd64_linux",
        "1.0.1__arm64_linux",
        "1.0.1__arm_linux",
        "1.0.1__ppc64le_linux",
        "1.0.1__s390x_linux",
        "1.0.6",
        "1.0.6__amd64_linux",
        "1.0.6__arm64_linux",
        "1.0.6__arm_linux",
        "1.0.6__ppc64le_linux",
        "1.0.6__s390x_linux",
        "1.1.3",
        "1.1.3__amd64_linux",
        "1.1.3__arm64_linux",
        "1.1.3__arm_linux",
        "1.1.3__ppc64le_linux",
        "1.1.3__s390x_linux",
        "1.2.2",
        "1.2.3",
        "1.2.4",
        "1.2.6",
        "1.3.0",
        "1.3.1",
        "1.5.0",
        "1.6.2",
        "1.6.5",
        "1.6.6",
        "1.6.7",
        "1.7.0"
    ]
}

docker.io/coredns/coredns

root@debian:/root # skopeo list-tags docker://docker.io/coredns/coredns
{
    "Repository": "docker.io/coredns/coredns",
    "Tags": [
        "0.9.10",
        "0.9.9",
        "006",
        "007",
        "008",
        "009",
        "010",
        "011",
        "1.0.0",
        "1.0.1",
        "1.0.2",
        "1.0.3",
        "1.0.4",
        "1.0.5",
        "1.0.6",
        "1.1.0",
        "1.1.1",
        "1.1.2",
        "1.1.3",
        "1.1.4",
        "1.2.0",
        "1.2.1",
        "1.2.2",
        "1.2.3",
        "1.2.4",
        "1.2.5",
        "1.2.6",
        "1.3.0",
        "1.3.1",
        "1.4.0",
        "1.5.0",
        "1.5.1",
        "1.5.2",
        "1.6.0",
        "1.6.1",
        "1.6.2",
        "1.6.3",
        "1.6.4",
        "1.6.5",
        "1.6.6",
        "1.6.7",
        "1.6.9",
        "1.7.0",
        "1.7.1",
        "1.8.0",
        "1.8.3",
        "coredns-amd64",
        "coredns-arm",
        "coredns-arm64",
        "coredns-ppc64le",
        "coredns-s390x",
        "latest"
    ]
}

floryut · 2021-04-29T07:24:23Z

You are right, should use k8s.gcr.io/coredns/coredns begin v1.21

These are coredns's tag in different image repo :

k8s.gcr.io/coredns/coredns

root@debian:/root # skopeo list-tags docker://k8s.gcr.io/coredns/coredns
{
    "Repository": "k8s.gcr.io/coredns/coredns",
    "Tags": [
        "v1.6.6",
        "v1.6.7",
        "v1.6.9",
        "v1.7.0",
        "v1.7.1",
        "v1.8.0",
        "v1.8.3"
    ]
}

Then let's switch to this {{ kube_image_repo }}/coredns/coredns and v1.x.x 🤷

roles/download/defaults/main.yml

MRoci · 2021-04-29T07:32:30Z

@floryut updated the PR in order to use new gcr naming conventions, but maybe doing so using kubeadm 1.20 this will lead in trying to pull k8s.gcr.io/coredns:v1.7.0 which is also non existing ?
Maybe we can add a check on kubeadm version to prevent this ?

floryut · 2021-04-29T07:55:12Z

@floryut updated the PR in order to use new gcr naming conventions, but maybe doing so using kubeadm 1.20 this will lead in trying to pull k8s.gcr.io/coredns:v1.7.0 which is also non existing ?
Maybe we can add a check on kubeadm version to prevent this ?

Hum I'll let reviewers provide their input but I would say that a warning in the release note will be enough to warn users.

champtar · 2021-04-29T10:50:54Z

I really like to be able to use latest kubespray release but the previous k8s version, can we just add a if depending on kubeadm / k8s version ?

floryut · 2021-04-29T12:06:07Z

I really like to be able to use latest kubespray release but the previous k8s version, can we just add a if depending on kubeadm / k8s version ?

~~Well as 1.19 also use coredns 1.7.0 it's ok~~
Ok I understand, sorry took me some time, the hardcoding "coredns/coredns" is only for 1.21, version 1.19/1.20 are still on "coredns" only, what a mess ~~
We do need to have a if on the kubernetes version.. keeping everyting on k8s.gcr.io, but depending on the version pointing to coredns/coredns:v1.xx or coredns:1.xx

roles/download/defaults/main.yml

MRoci · 2021-04-29T13:35:40Z

@floryut ok, now it should be able to handle both cases: with kubeadm >=1.21 it uses coredns/coredns:v1.xx, coredns:1.xx is used otherwise

follow new naming conventions for gcr's coredns image. starting from 1.21 kubeadm assumes it to be `coredns/coredns`: this causes the kubeadm deployment being unable to pull image, beacuse `v` was also added in image tag, until the role `kubernetes-apps` ovverides it with the old name, which is only compatible with <=1.7. Backward comptability with kubeadm <=1.20 is mantained checking kubernetes version and falling back to old names (`coredns:1.xx`) when the version is less than 1.21

champtar · 2021-04-30T14:40:51Z

/lgtm

Fix coredns image repo and tag typo for #7570

…ubernetes-sigs#7570) follow new naming conventions for gcr's coredns image. starting from 1.21 kubeadm assumes it to be `coredns/coredns`: this causes the kubeadm deployment being unable to pull image, beacuse `v` was also added in image tag, until the role `kubernetes-apps` ovverides it with the old name, which is only compatible with <=1.7. Backward comptability with kubeadm <=1.20 is mantained checking kubernetes version and falling back to old names (`coredns:1.xx`) when the version is less than 1.21

…gs#7561) Fix coredns image repo and tag typo for kubernetes-sigs#7570

…ubernetes-sigs#7570) follow new naming conventions for gcr's coredns image. starting from 1.21 kubeadm assumes it to be `coredns/coredns`: this causes the kubeadm deployment being unable to pull image, beacuse `v` was also added in image tag, until the role `kubernetes-apps` ovverides it with the old name, which is only compatible with <=1.7. Backward comptability with kubeadm <=1.20 is mantained checking kubernetes version and falling back to old names (`coredns:1.xx`) when the version is less than 1.21

…gs#7561) Fix coredns image repo and tag typo for kubernetes-sigs#7570

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2021

k8s-ci-robot requested review from EppO and holmsten April 28, 2021 15:52

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2021

k8s-ci-robot assigned mirwan Apr 28, 2021

floryut approved these changes Apr 28, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021

MRoci force-pushed the kubeadm-coredns-img branch from de83100 to f628dee Compare April 29, 2021 07:21

muzi502 reviewed Apr 29, 2021

View reviewed changes

roles/download/defaults/main.yml Outdated Show resolved Hide resolved

MRoci changed the title ~~switch to docker.io for kubeadm coredns addon~~ change kubeadm coredns addon images name to coredns/coredns Apr 29, 2021

floryut reviewed Apr 29, 2021

View reviewed changes

roles/download/defaults/main.yml Outdated Show resolved Hide resolved

MRoci force-pushed the kubeadm-coredns-img branch from f628dee to feec8ce Compare April 29, 2021 07:27

MRoci force-pushed the kubeadm-coredns-img branch from feec8ce to 94cb583 Compare April 29, 2021 13:31

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2021

floryut reviewed Apr 29, 2021

View reviewed changes

roles/download/defaults/main.yml Outdated Show resolved Hide resolved

MRoci force-pushed the kubeadm-coredns-img branch from 94cb583 to f4ae844 Compare April 29, 2021 13:47

k8s-ci-robot assigned champtar Apr 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021

k8s-ci-robot merged commit a0ee569 into kubernetes-sigs:master Apr 30, 2021

k8s-ci-robot pushed a commit that referenced this pull request May 11, 2021

Add script for generate download files and images list (#7561)

1d078e1

Fix coredns image repo and tag typo for #7570

floryut mentioned this pull request May 11, 2021

Release Proposal v2.16 #7602

Closed

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 17, 2021

Add script for generate download files and images list (kubernetes-si…

c45690f

…gs#7561) Fix coredns image repo and tag typo for kubernetes-sigs#7570

oomichi mentioned this pull request Nov 15, 2021

[2.17] fix imageRepository path for CoreDNS v1.8.0 #8182 #8183

Closed

sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022

Add script for generate download files and images list (kubernetes-si…

73306ee

…gs#7561) Fix coredns image repo and tag typo for kubernetes-sigs#7570

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change kubeadm coredns addon images name to `coredns/coredns` #7570

change kubeadm coredns addon images name to `coredns/coredns` #7570

MRoci commented Apr 28, 2021 •

edited

Loading

k8s-ci-robot commented Apr 28, 2021

k8s-ci-robot commented Apr 28, 2021

MRoci commented Apr 28, 2021

floryut left a comment

k8s-ci-robot commented Apr 28, 2021

tvanderka commented Apr 28, 2021

muzi502 commented Apr 29, 2021

floryut commented Apr 29, 2021

MRoci commented Apr 29, 2021 •

edited

Loading

floryut commented Apr 29, 2021

champtar commented Apr 29, 2021

floryut commented Apr 29, 2021 •

edited

Loading

MRoci commented Apr 29, 2021

champtar commented Apr 30, 2021

change kubeadm coredns addon images name to coredns/coredns #7570

change kubeadm coredns addon images name to coredns/coredns #7570

Conversation

MRoci commented Apr 28, 2021 • edited Loading

k8s-ci-robot commented Apr 28, 2021

k8s-ci-robot commented Apr 28, 2021

MRoci commented Apr 28, 2021

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 28, 2021

tvanderka commented Apr 28, 2021

muzi502 commented Apr 29, 2021

floryut commented Apr 29, 2021

MRoci commented Apr 29, 2021 • edited Loading

floryut commented Apr 29, 2021

champtar commented Apr 29, 2021

floryut commented Apr 29, 2021 • edited Loading

MRoci commented Apr 29, 2021

champtar commented Apr 30, 2021

change kubeadm coredns addon images name to `coredns/coredns` #7570

change kubeadm coredns addon images name to `coredns/coredns` #7570

MRoci commented Apr 28, 2021 •

edited

Loading

MRoci commented Apr 29, 2021 •

edited

Loading

floryut commented Apr 29, 2021 •

edited

Loading