add default empty value for etc_hosts_localhosts_dict_target #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/assign @floryut |
floryut
approved these changes
Apr 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oomichi
reviewed
Apr 28, 2021
| @@ -66,7 +66,7 @@ | |||
| state: present | |||
| backup: yes | |||
| unsafe_writes: yes | |||
| loop: "{{ etc_hosts_localhosts_dict_target|dict2items }}" | |||
| loop: "{{ etc_hosts_localhosts_dict_target|default({})|dict2items }}" | |||
There was a problem hiding this comment.
This change is the same as the existing line 58.
/lgtm
k8s-ci-robot
added
the
lgtm
LuckySB
added a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 12, 2021
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
add default value
playbook upgrade cluster fail, when download_run_once=true
at
kubespray/upgrade-cluster.yml
Line 45 in dfeed1c
because import_task: with when: staticaly added task to play with additional when clause
todo: change import_tasks to include_tasks