-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crio: add supported versions 1.20 and 1.21 and align default with k8s version #7562
crio: add supported versions 1.20 and 1.21 and align default with k8s version #7562
Conversation
Hi @cristicalin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ah thx, I changed that but while rebasing I forgot to change it back ~~ |
README.md also needs to be updated 😅 https://github.com/kubernetes-sigs/kubespray/blob/master/README.md#L135 |
89d3076
to
dd90859
Compare
oh well it was late! 😅 |
dd90859
to
4b78531
Compare
Molecule test failure seems to be a lemon. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
… version (kubernetes-sigs#7562) * crio: add supported versions 1.20 and 1.21 and align default with k8s version * cri-o: drop versions 1.17 and 1.18 from version matrix * update note on cri-o version alignment
… version (kubernetes-sigs#7562) * crio: add supported versions 1.20 and 1.21 and align default with k8s version * cri-o: drop versions 1.17 and 1.18 from version matrix * update note on cri-o version alignment
In #7544, we added versions 1.20 and 1.21 but the defaults were not aligned with the change.
What type of PR is this?
What this PR does / why we need it:
This PR adds the new cri-o versions to the
crio_kubernetes_version_matrix
dict and bumps the default cri-o version to 1.20 to align with the defaultkube_version
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: