Add condition for audit_webhook_mode batch #7444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the document[1], audit-webhook-batch-max-size and audit-webhook-batch-max-wait are used only in the batch mode. This adds a condition to avoid unnecessary writting on the config. [1]: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/#batching
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
floryut
approved these changes
Apr 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 12, 2021
According to the document[1], audit-webhook-batch-max-size and audit-webhook-batch-max-wait are used only in the batch mode. This adds a condition to avoid unnecessary writting on the config. [1]: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/#batching
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
According to the document[1], audit-webhook-batch-max-size and audit-webhook-batch-max-wait are used only in the batch mode. This adds a condition to avoid unnecessary writting on the config. [1]: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/#batching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
According to the document, audit-webhook-batch-max-size and audit-webhook-batch-max-wait are used only in the batch mode.
This adds a condition to avoid unnecessary writting on the config.
This comes from a review process of #7434
Does this PR introduce a user-facing change?: