Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom bird calico port #7419

Merged

Conversation

fcgravalos
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
Calico v3.16 added support for custom bird port to avoid colliding with other bird daemons running on the same servers, which it's our case. We run multiple bird daemons and having this flexibility in kubespray will make our lives easier.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds the ability to customize calico's bird port, via `calico_bird_listen_port` variable

@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi March 29, 2021 10:48
@k8s-ci-robot
Copy link
Contributor

Hi @fcgravalos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2021
@fcgravalos fcgravalos force-pushed the custom-calico-bgp-port branch from 9e9f5e8 to ae041b0 Compare March 29, 2021 12:47
@fcgravalos fcgravalos requested a review from champtar March 29, 2021 12:48
Copy link
Contributor

@champtar champtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@fcgravalos
Copy link
Contributor Author

/assign @chadswen

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, fcgravalos, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@fcgravalos
Copy link
Contributor Author

It looks like https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1136534558 failed because SSH was not available and timed out. Any chance we re-run it without running the whole test-suite?

@fcgravalos
Copy link
Contributor Author

This also failed for reasons unrelated to my change: https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1136534631

@k8s-ci-robot k8s-ci-robot merged commit 5dbce6a into kubernetes-sigs:master Mar 29, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 6, 2021
@floryut floryut mentioned this pull request May 11, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants