fix removing (worker) nodes #7391
Conversation
k8s-ci-robot
added
kind/bug
|
Hi @fourstepper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fourstepper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| - name: remove-node | Identify nodes to drain, ignore non-cluster nodes | ||
| shell: | | ||
| set -o pipefail |
There was a problem hiding this comment.
Due to this removal, the ansible-lint job is failed like
roles/remove-node/pre-remove/tasks/main.yml:11: [E306] Shells that use pipes should set the pipefail option
Do we need to remove this line?
/cc @oomichi
There was a problem hiding this comment.
As shown in the error, it seems that it's problematic to keep it. I might be missing something, though
There was a problem hiding this comment.
Just force bash shell instead of sh
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an issue with a missing dependency on jq when removing nodes, as well as fixing the syntax that has produced the following error:
failed: [control-plane-2] (item=worker-2) => {"ansible_loop_var": "item", "changed": false, "cmd": "set -o pipefail\n/usr/local/bin/kubectl get nodes -o json | jq .items[].metadata.name | jq \"select(. | test(\\\"^worker-2$\\\"))\"\n", "delta": "0:00:00.009442", "end": "2021-03-21 18:24:49.586123", "item": "worker-2", "msg": "non-zero return code", "rc": 2, "start": "2021-03-21 18:24:49.576681", "stderr": "/bin/sh: 1: set: Illegal option -o pipefail", "stderr_lines": ["/bin/sh: 1: set: Illegal option -o pipefail"], "stdout": "", "stdout_lines": []}