-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add etcd max snapshot and wals #7382
Conversation
Hi @liupeng0518. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, liupeng0518 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed the environment variable names and the default values according to https://etcd.io/docs/v2/configuration/
–max-snapshots
Maximum number of snapshot files to retain (0 is unlimited)
default: 5
env variable: ETCD_MAX_SNAPSHOTS
The default for users on Windows is unlimited, and manual purging down to 5 (or your preference for safety) is recommended.
–max-wals
Maximum number of wal files to retain (0 is unlimited)
default: 5
env variable: ETCD_MAX_WALS
The default for users on Windows is unlimited, and manual purging down to 5 (or your preference for safety) is recommended.
/ok-to-test
/lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add etcd flags: snapshot and wals
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: