-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default OCCM internal and public networks variables to empty lists #7380
Conversation
…ists Signed-off-by: Mikael Johansson <[email protected]>
Hi @mikejoh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mikejoh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…ists (kubernetes-sigs#7380) Signed-off-by: Mikael Johansson <[email protected]>
…ists (kubernetes-sigs#7380) Signed-off-by: Mikael Johansson <[email protected]>
What type of PR is this?
What this PR does / why we need it:
Change the defaults of the following variables:
to
to mitigate an off-by-one kind of problem when the OCCM (OpenStack Cloud Controller Manager), during node initialization, logs an error and leaving the nodes uninitialized. This happens when you don't want to specify any networks as internal or public and the defaults still adds an element of empty string. Further down the line, in the OCCM, a certain if-condition never evaluates since the resulting
[]string
slice data types are oflen() == 1
.Which issue(s) this PR fixes:
Fixes #7379
Special notes for your reviewer:
As i mentioned in the issue, there's work to be done in the OCCM project, i can create an issue there to start with.
Does this PR introduce a user-facing change?: