Add nodeselector and tolerations for metallb #7334

francoishernandez · 2021-03-02T18:00:31Z

/kind feature

What this PR does / why we need it:
This PR introduces variables to set tolerations and nodeSelector for metallb components (controller and speaker).
Variables are:

metallb_speaker_nodeselector
metallb_controller_nodeselector
metallb_speaker_tolerations
metallb_controller_tolerations

Which issue(s) this PR fixes:
Fixes #6806

Special notes for your reviewer:
Followed the same logic as the ingress_nginx addon, e.g. #3742

Does this PR introduce a user-facing change?:

Introduces optional `tolerations` and `nodeSelector` for metallb components (`controller` and `speaker`).

k8s-ci-robot · 2021-03-02T18:00:34Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-03-02T18:00:39Z

Welcome @francoishernandez!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-03-02T18:00:39Z

Hi @francoishernandez. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

francoishernandez · 2021-03-02T18:09:40Z

Hey guys,
I just signed the CLA.

oomichi

Thanks for doing this.
Most part seems good for me, that follows the same way of ingress_nginx.
Just one question.

oomichi · 2021-03-02T23:10:20Z

roles/kubernetes-apps/metallb/templates/metallb.yml.j2

+      # - effect: NoSchedule
+      #   key: node-role.kubernetes.io/master
+      # - effect: NoSchedule
+      #   key: node-role.kubernetes.io/control-plane


Why do we need to add commented-out lines 356-360?
Or did you want to keep the same lines for else case instead of commented-out lines?

My bad, this was for testing purposes before creating the variables. I'll remove it!

oomichi · 2021-03-02T23:30:43Z

/ok-to-test

oomichi · 2021-03-03T19:46:33Z

roles/kubernetes-apps/metallb/defaults/main.yml

@@ -6,3 +6,7 @@ metallb_port: "7472"
 metallb_limits_cpu: "100m"
 metallb_limits_mem: "100Mi"
 metallb_peers: []
+metallb_speaker_nodeselector: {}
+metallb_controller_nodeselector: {}
+metallb_speaker_tolerations: []


Can we set

- effect: NoSchedule key: node-role.kubernetes.io/master - effect: NoSchedule key: node-role.kubernetes.io/control-plane

as the default value of metallb_speaker_tolerations?
According to https://raw.githubusercontent.com/metallb/metallb/v0.9.5/manifests/metallb.yaml the toleration is specified on the manifest.
So I feel it is better to keep it as the default.

Agreed. Adressed in d47e38b.

Thanks for updating again.
Please rebase for the latest master branch as @floryut said to pass CI tests.
I will add /lgtm again after rebasing also.

/lgtm

k8s-ci-robot · 2021-03-05T20:22:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, francoishernandez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

floryut · 2021-03-05T20:25:42Z

@francoishernandez You need to rebase master for tests to succeed

oomichi · 2021-03-08T15:53:37Z

/lgtm

* add nodeselector and tolerations for metallb * remove unnecessary commented lines in metallb template * set default speaker toleration to match original manifest

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 2, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 2, 2021

k8s-ci-robot requested review from bozzo and oomichi March 2, 2021 18:00

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 2, 2021

oomichi reviewed Mar 2, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2021

oomichi reviewed Mar 3, 2021

View reviewed changes

francoishernandez force-pushed the metallb_tolerations branch from 9b0401c to d47e38b Compare March 4, 2021 08:50

floryut approved these changes Mar 5, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021

k8s-ci-robot assigned oomichi Mar 5, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021

francoishernandez added 3 commits March 8, 2021 08:38

add nodeselector and tolerations for metallb

dbdbdde

remove unnecessary commented lines in metallb template

4706af7

set default speaker toleration to match original manifest

827eb8c

francoishernandez force-pushed the metallb_tolerations branch from d47e38b to 827eb8c Compare March 8, 2021 08:39

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021

k8s-ci-robot merged commit c7db72e into kubernetes-sigs:master Mar 8, 2021

floryut mentioned this pull request May 11, 2021

Release Proposal v2.16 #7602

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nodeselector and tolerations for metallb #7334

Add nodeselector and tolerations for metallb #7334

francoishernandez commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

francoishernandez commented Mar 2, 2021

oomichi left a comment

oomichi Mar 2, 2021

francoishernandez Mar 3, 2021

oomichi commented Mar 2, 2021

oomichi Mar 3, 2021

francoishernandez Mar 4, 2021 •

edited

Loading

oomichi Mar 5, 2021 •

edited

Loading

k8s-ci-robot commented Mar 5, 2021

floryut commented Mar 5, 2021

oomichi commented Mar 8, 2021

Add nodeselector and tolerations for metallb #7334

Add nodeselector and tolerations for metallb #7334

Conversation

francoishernandez commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

k8s-ci-robot commented Mar 2, 2021

francoishernandez commented Mar 2, 2021

oomichi left a comment

Choose a reason for hiding this comment

oomichi Mar 2, 2021

Choose a reason for hiding this comment

francoishernandez Mar 3, 2021

Choose a reason for hiding this comment

oomichi commented Mar 2, 2021

oomichi Mar 3, 2021

Choose a reason for hiding this comment

francoishernandez Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

oomichi Mar 5, 2021 • edited Loading

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 5, 2021

floryut commented Mar 5, 2021

oomichi commented Mar 8, 2021

francoishernandez Mar 4, 2021 •

edited

Loading

oomichi Mar 5, 2021 •

edited

Loading