facts.yaml: reduce the number of setup calls by ~7x #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
size/S
champtar
force-pushed
the
facts-speedup
branch
2 times, most recently
from
dfa9d0b to
bd7d404
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
What are you holding the PR for ? |
|
Waiting for #7287 to be merged so I can rebase on top |
champtar
force-pushed
the
facts-speedup
branch
2 times, most recently
from
0b37c35 to
ff054e0
Compare
Before this commit, we were gathering: 1 !all 7 network 7 hardware After we are gathering: 1 !all 1 network 1 hardware ansible_distribution_major_version is gathered by '!all' Signed-off-by: Etienne Champetier <[email protected]>
champtar
force-pushed
the
facts-speedup
branch
from
ff054e0 to
c9e3ce2
Compare
k8s-ci-robot
added
size/S
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
floryut
approved these changes
Feb 16, 2021
k8s-ci-robot
added
the
approved
LuckySB
approved these changes
Feb 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, floryut, LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
champtar
added a commit
to champtar/kubespray
that referenced
this pull request
Feb 17, 2021
…7286) Before this commit, we were gathering: 1 !all 7 network 7 hardware After we are gathering: 1 !all 1 network 1 hardware ansible_distribution_major_version is gathered by '!all' Signed-off-by: Etienne Champetier <[email protected]> (cherry picked from commit fb8b075)
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 22, 2021
Before this commit, we were gathering: 1 !all 7 network 7 hardware After we are gathering: 1 !all 1 network 1 hardware ansible_distribution_major_version is gathered by '!all' Signed-off-by: Etienne Champetier <[email protected]> (cherry picked from commit fb8b075)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Apr 6, 2021
…7286) Before this commit, we were gathering: 1 !all 7 network 7 hardware After we are gathering: 1 !all 1 network 1 hardware ansible_distribution_major_version is gathered by '!all' Signed-off-by: Etienne Champetier <[email protected]>
Closed
|
This could have been the source of poor Ansible scaling that I observed on a cluster with ~ 200 nodes . Nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we were gathering:
1 !all
7 network
7 hardware
After we are gathering:
1 !all
1 network
1 hardware
ansible_distribution_major_version is gathered by '!all'
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: