Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change nginx default HTTPS protocol from "SSLv2" to "TLSv1.2 TLSv1.3" #7144

Merged
merged 1 commit into from
Jan 13, 2021
Merged

change nginx default HTTPS protocol from "SSLv2" to "TLSv1.2 TLSv1.3" #7144

merged 1 commit into from
Jan 13, 2021

Conversation

floryut
Copy link
Member

@floryut floryut commented Jan 13, 2021

Cherry-pick of #6912

What type of PR is this?
/kind flake

What this PR does / why we need it:

In the sample inventory, the addons.yaml (l. 102) installs ingress-nginx with SSLv2 protocol by default. CHanged this to "TLSv1.2 TLSv1.3".

Which issue(s) this PR fixes:
Fixes #6904

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi January 13, 2021 10:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2021
@floryut floryut mentioned this pull request Jan 13, 2021
Closed
@oomichi
Copy link
Contributor

oomichi commented Jan 13, 2021

Is this PR for master branch?
#6912 has fixed for master branch already, I am a little confused.

@floryut
Copy link
Member Author

floryut commented Jan 13, 2021

Is this PR for master branch?
#6912 has fixed for master branch already, I am a little confused.

See my comment here #6912 (comment) :)

@oomichi
Copy link
Contributor

oomichi commented Jan 13, 2021

Is this PR for master branch?
#6912 has fixed for master branch already, I am a little confused.

See my comment here #6912 (comment) :)

Ah, OK. I see it :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit b59035d into kubernetes-sigs:master Jan 13, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Feb 1, 2021
@floryut @LuckySB
change nginx default HTTPS protocol from "SSLv2" to "TLSv1.2 TLSv1.3" (…
f99ebf2 
…kubernetes-sigs#7144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default ingress-nginx config and replace the default "SSLv2" protocol
3 participants
@floryut @k8s-ci-robot @oomichi