Disable docker-ce yum repo by default / cleanups

[champtar]

Upgrading docker / containerd without adapting the configuration might break the node,
so disable docker-ce repo by default.
We are already using dpkg hold for Debian.

All containerd.io packages provide /usr/bin/runc, so no need to check

yum_conf was never used for containerd

module_hotfixes should not be needed with the EL8 repo

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Disable docker-ce yum repo by default

[k8s-ci-robot]

Hi @champtar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LuckySB]

/ok-to-test

[LuckySB]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LuckySB]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[EppO]

/lgtm

[floryut]

@champtar since this, containerd build are failing to install packages on Fedora
https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/941643413

Monday 04 January 2021  01:16:00 +0000 (0:00:01.890)       0:07:34.729 ******** 
TASK [container-engine/containerd : ensure containerd packages are installed] ***
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/container-engine/containerd/tasks/main.yml:93
Monday 04 January 2021  01:16:01 +0000 (0:00:00.856)       0:07:35.585 ******** 
FAILED - RETRYING: ensure containerd packages are installed (4 retries left).
FAILED - RETRYING: ensure containerd packages are installed (4 retries left).
FAILED - RETRYING: ensure containerd packages are installed (3 retries left).
FAILED - RETRYING: ensure containerd packages are installed (3 retries left).
FAILED - RETRYING: ensure containerd packages are installed (2 retries left).
FAILED - RETRYING: ensure containerd packages are installed (2 retries left).
FAILED - RETRYING: ensure containerd packages are installed (1 retries left).
FAILED - RETRYING: ensure containerd packages are installed (1 retries left).
failed: [instance-1] (item={'name': 'containerd.io-1.3.9-3.1.fc32'}) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "failures": ["containerd.io-1.3.9-3.1.fc32 No match for argument: containerd.io-1.3.9-3.1.fc32"], "item": {"name": "containerd.io-1.3.9-3.1.fc32"}, "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}
...ignoring
failed: [instance-2] (item={'name': 'containerd.io-1.3.9-3.1.fc32'}) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "failures": ["containerd.io-1.3.9-3.1.fc32 No match for argument: containerd.io-1.3.9-3.1.fc32"], "item": {"name": "containerd.io-1.3.9-3.1.fc32"}, "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}

Do we need to enable repo for fedora ? Any other idea ?

[champtar]

indeed roles/container-engine/containerd/vars/fedora.yml is wrong, let me send a PR

[champtar]

=> #7093