-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added boto3 as dependency required by kubespray-aws-inventory.py #6890
fix: added boto3 as dependency required by kubespray-aws-inventory.py #6890
Conversation
Welcome @Rajpratik71! |
Hi @Rajpratik71. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating.
/lgtm
IMHO I'd like to suggest to include license as comment, like:
This information can eventually helps to track some license constraints. /lgtm |
@Rajpratik71 Would you care to update ? |
@floryut and @electrocucaracha done as requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EppO, floryut, Rajpratik71 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@Rajpratik71 Could you please rebase master ? There was a CI issue which is now fixed |
Added "boto3" as dependency in "requirements.txt" which is required by "kubespray-aws-inventory.py". Signed-off-by: Pratik raj <[email protected]>
/lgtm |
…kubernetes-sigs#6890) Added "boto3" as dependency in "requirements.txt" which is required by "kubespray-aws-inventory.py". Signed-off-by: Pratik raj <[email protected]>
What type of PR is this?
What this PR does / why we need it:
This PR will fix missing dependency problem for "kubespray-aws-inventory.py"
Which issue(s) this PR fixes:
Fixes N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?: