-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets cgroup v1 in Fedora +31 #6862
Sets cgroup v1 in Fedora +31 #6862
Conversation
Fedora 31 uses Cgroups v2 by default. This change by passes the kernel parameter systemd.unified_cgroup_hierarchy=0. Signed-off-by: Victor Morales <[email protected]>
Hi @electrocucaracha. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
when: | ||
- ansible_distribution == "Fedora" | ||
- (ansible_distribution_major_version | int) >= 31 | ||
- ansible_proc_cmdline['systemd.unified_cgroup_hierarchy'] is not defined or ansible_proc_cmdline['systemd.unified_cgroup_hierarchy'] != '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using block:
for merging when
conditions into a single one like
- block:
- name: disable unified_cgroup_hierarchy in Fedora 31+
command: grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
- name: reboot in Fedora 31+
reboot:
when:
- ansible_distribution == "Fedora"
- (ansible_distribution_major_version | int) >= 31
- ansible_proc_cmdline['systemd.unified_cgroup_hierarchy'] is not defined or ansible_proc_cmdline['systemd.unified_cgroup_hierarchy'] != '0'
for the readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, I just wonder if should be nice to sync that with docker and containerd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice point.
To keep the scope of this PR small and easy, It is better to create another PR for the above docker and containerd cases, I feel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically avoid blocks and instead use include_tasks module referencing another file in Kubespray. The code in this PR is just fine (2 tasks doesn't really merit a separate file, but 4+ would)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, floryut, mattymo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fedora 31 uses Cgroups v2 by default. This change by passes the kernel parameter systemd.unified_cgroup_hierarchy=0. Signed-off-by: Victor Morales <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Kubelet service doesn't start if CRI-O is selected as runtime manager for Fedora distros
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Use
container_manager: crio
on a Fedora +31 releaseDoes this PR introduce a user-facing change?:
NONE