Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube-ovn to 1.5.2 #6610

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Update kube-ovn to 1.5.2 #6610

merged 1 commit into from
Nov 26, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Sep 1, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update kube-ovn to latest release

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2020
oomichi
oomichi reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most part seems good for me, just one comment.

/cc @oomichi

roles/network_plugin/kube-ovn/templates/cni-ovn.yml.j2 Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi September 2, 2020 17:19
@floryut floryut force-pushed the kube-ovn-update branch 3 times, most recently from 46cfb5c to 1f2a4ee Compare September 3, 2020 08:06
@oomichi
Copy link
Contributor

oomichi commented Sep 3, 2020

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@floryut floryut marked this pull request as draft September 4, 2020 21:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2020
@mattymo
Copy link
Contributor

mattymo commented Sep 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2020
@floryut floryut force-pushed the kube-ovn-update branch 2 times, most recently from 1235b4a to a3d3fb6 Compare September 7, 2020 20:11
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2020
@floryut floryut force-pushed the kube-ovn-update branch 6 times, most recently from da02909 to 93e7a1a Compare September 10, 2020 18:38
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2020
@floryut floryut force-pushed the kube-ovn-update branch 2 times, most recently from 17edc16 to 4467fc9 Compare September 28, 2020 19:49
@floryut floryut force-pushed the kube-ovn-update branch 3 times, most recently from 02b27a7 to 590ea6d Compare October 9, 2020 21:29
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@floryut floryut force-pushed the kube-ovn-update branch 3 times, most recently from 34e7762 to be727d1 Compare October 12, 2020 06:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2020
@floryut floryut force-pushed the kube-ovn-update branch 2 times, most recently from 8f981ca to a4176fa Compare October 26, 2020 08:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2020
@floryut floryut force-pushed the kube-ovn-update branch 2 times, most recently from 646830e to cbcffb8 Compare November 6, 2020 11:05
@floryut floryut force-pushed the kube-ovn-update branch 2 times, most recently from 5e22382 to 2a93d28 Compare November 23, 2020 08:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2020
@floryut floryut changed the title Update kube-ovn to 1.5.0 Update kube-ovn to 1.5.2 Nov 23, 2020
@floryut floryut marked this pull request as ready for review November 23, 2020 09:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2020
@floryut
Copy link
Member Author

floryut commented Nov 24, 2020

@oomichi @EppO Back on track !

After a loooooooot of discussion with kube-ovn maintainers, they managed to find the bug with kube-ovn 1.4.0/1.5.0 and 1.5.1 and it is now fixed in 1.5.2 ! 🥳

@EppO
Copy link
Contributor

EppO commented Nov 26, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit d407014 into kubernetes-sigs:master Nov 26, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@floryut @LuckySB
Update kube-ovn to 1.5.2 (kubernetes-sigs#6610)
c79c2ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@EppO EppO

@mattymo mattymo

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@floryut @oomichi @mattymo @k8s-ci-robot @EppO