Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx ingress to 0.35.0 #6599

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Aug 28, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Well... update again nginx ingress, 0.35.0 is released, best to ship it with 2.14

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
Rolling back my changes with k8s.gcr.io didn't understood what nginx-ingress did, but everything is on the main repo

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten August 28, 2020 14:46
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2020
@floryut floryut force-pushed the nginx_update_again branch from 3efbdd7 to 80c00ca Compare August 28, 2020 14:46
Copy link
Contributor

@Miouge1 Miouge1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @floryut !

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0665b45 into kubernetes-sigs:master Aug 31, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants