-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pypy download url in bootstrap script #6555
Updated pypy download url in bootstrap script #6555
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @abyth! |
Hi @abyth. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1845251
to
cc45e49
Compare
43ee459
to
a65e3d1
Compare
The bootstrap-os role uses a bootstrap script to provision a python interpreter on flatcar and container os hosts. As the pypy project switched to another hoster, the download url changed. If applied this will use the new proper pypy download url in bootstrap script
@abyth Thank you for the PR, could you please change your commit message, using something understandable (only /ok-to-test |
a65e3d1
to
fb74371
Compare
/lgtm |
Agreed, i was tinkering with the commit message and body due to the k8s-ci-robot complaining about them. Anything more i could and/or should do? |
All good waiting on an approver to drop by |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyth, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The bootstrap-os role uses a bootstrap script to provision a python interpreter on flatcar and container os hosts. As the pypy project switched to another hoster, the download url changed. If applied this will use the new proper pypy download url in bootstrap script
/kind bug
What this PR does / why we need it:
The pypy project changed its hoster leading to a broken download url in the bootstrap script for flatcar and container os hosts
Which issue(s) this PR fixes:
Fixes #6554
Special notes for your reviewer:
Does this PR introduce a user-facing change?: