Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s hashes and set default version to 1.18.8 #6532

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Update k8s hashes and set default version to 1.18.8 #6532

merged 1 commit into from
Aug 21, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Aug 14, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update hashes and set new version

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Release artifacts for 1.18.7 and 1.17.10 are incomplete. Do not use these releases. (From Kubernetes Github)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO August 14, 2020 07:24
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2020
floryut
floryut commented Aug 14, 2020
View reviewed changes
roles/kubernetes/preinstall/defaults/main.yml
@@ -1,6 +1,4 @@
---
run_gitinfos: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really intended but this variable is unused.. if need be I can cleanup the PR and remove this change

@oomichi
Copy link
Contributor

oomichi commented Aug 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@oomichi oomichi mentioned this pull request Aug 14, 2020
Merged
@floryut
Copy link
Member Author

floryut commented Aug 18, 2020

Waiting on #6536 to be merged first.

@woopstar
Copy link
Member

ci failed @floryut

@floryut
Copy link
Member Author

floryut commented Aug 20, 2020

ci failed @floryut

Yup I need to rebase #6536 as Sonobuoy current version failed with 1.18.8+ :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2020
@floryut
Copy link
Member Author

floryut commented Aug 20, 2020

And done ! :)

@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 142b9e1 into kubernetes-sigs:master Aug 21, 2020
@hjanuschka
Copy link
Contributor

https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/kube-proxy?gcrImageListsize=30&gcrImageListquery=%255B%255D&gcrImageListsort=-uploaded

is missing 1.18.8 and i cannot pull gcr.io/google-containers/kube-proxy:1.18.8

@hjanuschka
Copy link
Contributor

ohh my fault, missed this https://github.com/kubernetes-sigs/kubespray/pull/5764/files#diff-7f53d043e9db4034591c6611967699f3L26 in my conf

@Miouge1 Miouge1 mentioned this pull request Aug 31, 2020
Merged
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
@floryut @LuckySB
Update k8s hashes and set default version to 1.18.8 (kubernetes-sigs#…
f3fe317 
…6532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skaronator Skaronator Skaronator approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@floryut @oomichi @woopstar @k8s-ci-robot @hjanuschka @Skaronator