Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle calico-rr nodes as workers so they get upgraded too #6447

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Handle calico-rr nodes as workers so they get upgraded too #6447

merged 2 commits into from
Sep 24, 2020

Conversation

gaima8
Copy link
Contributor

@gaima8 gaima8 commented Jul 23, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:

Route-reflector nodes don't get upgraded by upgrade-cluster.yml.

Which issue(s) this PR fixes:

Fixes #6386

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gaima8. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut July 23, 2020 20:14
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2020
@floryut
Copy link
Member

floryut commented Jul 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020
@gaima8
Copy link
Contributor Author

gaima8 commented Jul 24, 2020 •
edited
Loading

I've modified another task to run on calico-rr nodes too in 8f2e263

Upgrade calico and external cloud provider ....

Without this /usr/local/bin/calicoctl.sh doesn't get installed on the route reflectors during upgrade.

This bit me during a 2.10.4 to 2.11.2 upgrade.
2.11.2 expects /usr/local/bin/calicoctl.sh to exist on route-reflectors and 2.10.x (.0 and .4) didn't install it during an upgrade from 2.9.0.
Both of my changes really should be backported to earlier releases. I'm not sure how best to go about that however.

@gaima8 gaima8 mentioned this pull request Jul 28, 2020
Closed
@Miouge1
Copy link
Contributor

Miouge1 commented Sep 24, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaima8, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@floryut
Copy link
Member

floryut commented Sep 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@floryut
Copy link
Member

floryut commented Sep 24, 2020

@gaima8 sorry for the long delay

@k8s-ci-robot k8s-ci-robot merged commit 50e8a52 into kubernetes-sigs:master Sep 24, 2020
@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@gaima8 @LuckySB
Handle calico-rr nodes as workers so they get upgraded too (kubernete…
41ca35e 
…s-sigs#6447)

* Handle calico-rr nodes as workers so they get upgraded too

* calico-rr nodes run 'calico and external cloud provider' too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade-cluster.yml not upgrade kubeadm/kubectl on route reflectors (calico-rr)
4 participants
@gaima8 @k8s-ci-robot @floryut @Miouge1