Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add audit webhook support #6317

Merged
merged 2 commits into from
Jul 20, 2020
Merged

add audit webhook support #6317

merged 2 commits into from
Jul 20, 2020

Conversation

kmlebedev
Copy link
Contributor

@kmlebedev kmlebedev commented Jun 24, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

webhook backends can be configured for sends audit events to a remote API

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kmlebedev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2020
@kmlebedev
Copy link
Contributor Author

/assign @woopsta

@k8s-ci-robot
Copy link
Contributor

@kmlebedev: GitHub didn't allow me to assign the following users: woopsta.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @woopsta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kmlebedev kmlebedev mentioned this pull request Jun 24, 2020
Closed
@kmlebedev
Copy link
Contributor Author

/assign @woopsta

@k8s-ci-robot
Copy link
Contributor

@kmlebedev: GitHub didn't allow me to assign the following users: woopsta.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @woopsta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kmlebedev
Copy link
Contributor Author

/assign @woopstar

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 24, 2020

@kmlebedev thank you for the contribution.

First thing is to fix the CLA status, the CLA bot added some info about it here: #6317 (comment)

@kmlebedev
Copy link
Contributor Author

the CLA status fixed

@kmlebedev
Copy link
Contributor Author

@kmlebedev thank you for the contribution.

First thing is to fix the CLA status, the CLA bot added some info about it here: #6317 (comment)
I think I fixed it. How CLA bot update info ?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 8, 2020
@kmlebedev
Copy link
Contributor Author

@woopstar Need ok to test

@floryut
Copy link
Member

floryut commented Jul 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 15, 2020

Can you add a description to this PR?

@kmlebedev
Copy link
Contributor Author

Can you add a description to this PR?
@Miouge1 Yes. Enough?

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 16, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmlebedev, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@floryut
Copy link
Member

floryut commented Jul 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit a7ec0ed into kubernetes-sigs:master Jul 20, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 22, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
f035921 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Upgrade etcd to 3.4.3 (kubernetes-sigs#5998)
  add audit webhook support (kubernetes-sigs#6317)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@kmlebedev @LuckySB
add audit webhook support (kubernetes-sigs#6317)
3ce8e1b 
* add audit webhook support

* use generic name auditsink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hafe hafe hafe left review comments

@bozzo bozzo Awaiting requested review from bozzo

@floryut floryut Awaiting requested review from floryut

Assignees

@woopstar woopstar

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kmlebedev @k8s-ci-robot @Miouge1 @floryut @hafe @woopstar