-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ectd node before reset #6099
remove ectd node before reset #6099
Conversation
Hi @lexxxel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @woopstar
On Thu, May 7, 2020 at 6:13 PM +0200, "Kubernetes Prow Robot" <[email protected]> wrote:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lexxxel
To complete the pull request process, please assign woopstar
You can assign the PR to them by writing /assign @woopstar in a comment when ready.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@lexxxel Could you rebase ? tests failure are fix in master in recent commits, thank you! |
3add5f4
to
8a70517
Compare
@floryut I rebased, but the piplines look like stuck, don't they? |
Thanks, give the CI some time ^^ |
8a70517
to
399d026
Compare
399d026
to
fd3dd22
Compare
Is something wrong with the CI or with my PR? |
CI issue, I restarted your job don't worry :) |
Looks reasonable /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lexxxel, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
remove etcd nodes before reseting them
Which issue(s) this PR fixes:
Fixes #6084
Special notes for your reviewer:
I didn't know were to put the roles, so I created a new one. I'm very open for refactoring suggestions.
Does this PR introduce a user-facing change?: