Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ectd node before reset #6099

Merged

Conversation

lexxxel
Copy link
Contributor

@lexxxel lexxxel commented May 7, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
remove etcd nodes before reseting them

Which issue(s) this PR fixes:

Fixes #6084

Special notes for your reviewer:
I didn't know were to put the roles, so I created a new one. I'm very open for refactoring suggestions.

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lexxxel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut May 7, 2020 16:13
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2020
@lexxxel lexxxel changed the title remove ectd node in pre step, instead of post step remove ectd node before reset May 7, 2020
@lexxxel
Copy link
Contributor Author

lexxxel commented May 7, 2020 via email

@floryut
Copy link
Member

floryut commented May 8, 2020

@lexxxel Could you rebase ? tests failure are fix in master in recent commits, thank you!

@lexxxel lexxxel force-pushed the feature/fix_etcd_node_removal branch from 3add5f4 to 8a70517 Compare May 8, 2020 07:57
@lexxxel
Copy link
Contributor Author

lexxxel commented May 8, 2020

@floryut I rebased, but the piplines look like stuck, don't they?

@floryut
Copy link
Member

floryut commented May 8, 2020

@floryut I rebased, but the piplines look like stuck, don't they?

Thanks, give the CI some time ^^

@lexxxel lexxxel force-pushed the feature/fix_etcd_node_removal branch from 8a70517 to 399d026 Compare May 11, 2020 08:06
@lexxxel lexxxel force-pushed the feature/fix_etcd_node_removal branch from 399d026 to fd3dd22 Compare May 12, 2020 07:07
@lexxxel
Copy link
Contributor Author

lexxxel commented May 12, 2020

Is something wrong with the CI or with my PR?
fatal: [instance-2]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host 172.30.72.53 port 22: Connection refused", "unreachable": true}

@floryut
Copy link
Member

floryut commented May 12, 2020

Is something wrong with the CI or with my PR?
fatal: [instance-2]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host 172.30.72.53 port 22: Connection refused", "unreachable": true}

CI issue, I restarted your job don't worry :)

@floryut
Copy link
Member

floryut commented Jun 5, 2020

/lgtm
WDYT @LuckySB / @Miouge1 ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 9, 2020

Looks reasonable

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lexxxel, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7712bd0 into kubernetes-sigs:master Jun 9, 2020
@lexxxel lexxxel deleted the feature/fix_etcd_node_removal branch June 9, 2020 12:39
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ectd broken after node-remove.yml of an etcd master
5 participants