Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liveness probe for cilium operator #6016

Merged

Conversation

mqasimsarfraz
Copy link
Contributor

What type of PR is this?
/kind bug
Which issue(s) this PR fixes:

Fixes #6015

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten April 24, 2020 11:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mqasimsarfraz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2020
@mqasimsarfraz
Copy link
Contributor Author

/assign @LuckySB

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 24, 2020

@mqasimsarfraz can you rebase on latest master? A new variable has been introduced in CI.

@mqasimsarfraz mqasimsarfraz force-pushed the fix-cilium-operator-deploy branch from 3f68ff9 to c68fcc8 Compare April 24, 2020 13:16
@mqasimsarfraz
Copy link
Contributor Author

@Miouge1 just did the rebase! 👍

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@floryut
Copy link
Member

floryut commented Apr 26, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2020
@woopstar
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MQasimSarfraz, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 52edd4c into kubernetes-sigs:master Apr 27, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium Operator keeps on restarting
5 participants