Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize PodSecurityPolicies from inventory #5920

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Customize PodSecurityPolicies from inventory #5920

merged 2 commits into from
Apr 15, 2020

Conversation

pasqualet
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Customize the PodSecurityPolicies from the inventory

Does this PR introduce a user-facing change?:

Add configuration for restricted and privileged PodSecurityPolicySpec

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pasqualet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten April 9, 2020 15:14
@pasqualet
Copy link
Contributor Author

/assign @LuckySB

@LuckySB
Copy link
Contributor

LuckySB commented Apr 9, 2020

please fix yamllint errors

@LuckySB
Copy link
Contributor

LuckySB commented Apr 9, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
Miouge1
Miouge1 reviewed Apr 14, 2020
View reviewed changes
roles/kubernetes-apps/cluster_roles/templates/psp.yml.j2
readOnlyRootFilesystem: false
forbiddenSysctls:
- '*'
{{ podsecuritypolicy_restricted_spec | to_yaml(indent=2, width=1337) | indent(width=2) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we indent=4 to start with?

@Miouge1 Miouge1 added this to the 2.13 milestone Apr 14, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 15, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, Miouge1, pasqualet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00efc63 into kubernetes-sigs:master Apr 15, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 18, 2020
@pasqualet @LuckySB
Customize PodSecurityPolicies from inventory (kubernetes-sigs#5920)
2c1f4bc 
* Customize PodSecurityPolicies from inventory

* Fixed yaml indentation
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
@pasqualet pasqualet mentioned this pull request Nov 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miouge1 Miouge1 Miouge1 left review comments

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@LuckySB LuckySB

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@pasqualet @k8s-ci-robot @LuckySB @Miouge1